Add diff command line mode #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the command line Parser along with a basic implementation for the diff of two expressions after normalizing them. This reuses the existing mechanism to diff two dhall expressions and render a pretty diff Signed-off-by: Basile Henry <bjm.henry@gmail.com>
Gabriella439
reviewed
Jun 8, 2018
src/Dhall/Main.hs
Outdated
| expr <- throws (Dhall.Parser.exprFromText inputName exprRaw) | ||
| load expr | ||
|
|
||
| expression1 <- parseAndResolve "(expr1)" expr1 |
There was a problem hiding this comment.
You can use Dhall.inputExpr in place of parseAndResolve
The main difference is that inputExpr also type-checks the input, which is necessary to ensure that the expression is safe to normalize for diffing purposes
Signed-off-by: Basile Henry <bjm.henry@gmail.com>
|
Awesome job! Thank you :) |
|
Thanks, this is going to be really useful! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #431
Add the command line Parser along with a basic implementation for the diff of two expressions after normalizing them. This reuses the existing mechanism to diff two dhall expressions and render a pretty diff