Preserve parentheses when formatting field access of an import #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #453 This updates the pretty-printing logic to match the precedence of the grammar. The immediate motivation for this is to ensure that `dhall format` doesn't remove parentheses around an import being accessed like a record, which would leave behind invalid Dhall code.
This was referenced Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #453
This updates the pretty-printing logic to match the precedence of the grammar.
The immediate motivation for this is to ensure that
dhall formatdoesn'tremove parentheses around an import being accessed like a record, which would
leave behind invalid Dhall code.