Add freeze command #486
Merged
Add freeze command #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Dhall/Main.hs
Outdated
| @@ -139,6 +142,19 @@ parseMode = | |||
| parserWithHelper = Options.Applicative.helper <*> parser | |||
| parser = Format <$> optional parseInplace | |||
|
|
|||
| freezeSubcommand = | |||
There was a problem hiding this comment.
I think you can simplify this as:
freezeSubcommand = subcommand "freeze" "Add hashes to all import statements of an expression" parseFreeze
where
parseFreeze = Freeze <$> optional parseInplace| where | ||
| fromStdin = System.IO.hSetEncoding System.IO.stdin System.IO.utf8 >> Data.Text.IO.getContents | ||
|
|
||
| hashImport :: Import -> IO Import |
There was a problem hiding this comment.
I think you should also export this utility since it is handy for people using the Haskell API
|
Added a paragraph on freeze to the Tutorial, please take a look. |
Gabriella439
approved these changes
Jun 26, 2018
src/Dhall/Tutorial.hs
Outdated
| -- | ||
| -- If you have a file which either doesn't already use hashed imports, | ||
| -- or you changed some of the imports and want to update the hashes you can use the | ||
| -- freeze command to either add or updated hashes: |
src/Dhall/Tutorial.hs
Outdated
| -- | ||
| -- > cat foo.dhall | ||
| -- '' | ||
| -- let replicate = ./r.dhall |
There was a problem hiding this comment.
Maybe use the GitHub URL for the import so that users can reproduce the example and also so that I can later add the example to the test suite
added 6 commits
June 26, 2018 19:04
The freeze command .. - takes input from stdin or file - traverses the Expression adding hashes to imports - writes result to stdout or file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
freezecommand as described in #437Given
the freeze command will produce:
The PR doesn't include tests or updates to
Tutorial.hs- can those be done separately or should those be included to make this eligible for merge?Thanks to @Gabriel439 and @ocharles for the help on this.