Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parse error for IPv4-mapped IPv6 addresses #632

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

drvirgilio
Copy link
Contributor

This is a simple fix for a parse error which isn't compliant with the specification. The issue is that h16 partially matches an IPv4 address but cannot backtrack when it fails.

> dhall format <<< 'https://[::192.168.0.1]/file'

Error: Invalid input

(stdin):1:14:
  |
1 | https://[::192.168.0.1]/file
  |              ^
unexpected '.'
expecting ']'

@Gabriella439 Gabriella439 merged commit 87aa062 into dhall-lang:master Oct 11, 2018
@Gabriella439
Copy link
Collaborator

Thank you! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants