fix: package exports for usage in plugins

[rubenkaiser]

named export of lambda for usage in plugins like sqs-offline or eventbridge-offline

[abhijeet-toptal]

@rubenkaiser do you know when are we expecting this PR to be merged? I am blocked on using eventbridge-offline with latest version of serverless-offline. Thanks!

[rubenkaiser]

I have no control over that. Hopefully it will be merged soon after which I will release a new version of serverless-offline-eventbridge and submit a PR for an update in offline-sns.

[dnalborczyk]

thank you for the PR @rubenkaiser !

you mentioned here: rubenkaiser/serverless-offline-eventBridge#60 (comment) that other plugins (e.g. sqs?) are importing "several things". I haven't found time to look into it yet, but do you know by any chance what else is needed - other than the Lambda class?

[dnalborczyk]

I was just digging through the node.js documentation, I'm not very familiar with the fairly new package exports myself, but it appears there might be one additional alternative: subpath exports https://nodejs.org/dist/latest-v18.x/docs/api/packages.html#subpath-exports

I wonder if we could (or even should?) do something similar mentioned here: https://nodejs.org/dist/latest-v18.x/docs/api/packages.html#extensions-in-subpaths

e.g.

import Lambda from 'serverless-offline/Lambda'

I'm contemplating a bit and I believe I'm leaning more towards that approach.

what are your opinions on this matter?

[rubenkaiser]

In my test setup I first tried this approach as it seems to be the nicest solution. For some reason I kept getting errors importing the submodules. Not sure why. I will have another look somewhere next week.

[dnalborczyk]

@rubenkaiser could you have a look if this would work for you: #1552

[dnalborczyk]

@rubenkaiser sorry, linked to your own PR 🤦 😄

I meant this one: #1561

[dnalborczyk]

super seeded by: #1561