Skip to content

Commit 866a4b5

Browse files
alan-agius4dherges
authored andcommitted
feat: remove deprecated code (#773)
BREAKING CHANGE: Removes several deprecated code items. - option `sassIncludePaths` is removed, please use `styleIncludePaths` instead - option `workingDirectory` is removed, removed corresponding getter from `NgPackage` class - method `createNgPackage` removed from programmatic API - removed `NgArtefacts` class from API - removed `BuildStep` interface from API
1 parent ea3a877 commit 866a4b5

File tree

7 files changed

+3
-196
lines changed

7 files changed

+3
-196
lines changed

integration/samples/scss-paths/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"ngPackage": {
1616
"lib": {
1717
"entryFile": "public_api.ts",
18-
"sassIncludePaths": ["./assets"]
18+
"styleIncludePaths": ["./assets"]
1919
}
2020
}
2121
}

integration/samples/scss-paths/sub-module/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"ngPackage": {
1313
"lib": {
1414
"entryFile": "index.ts",
15-
"sassIncludePaths": ["../assets", "./assets"]
15+
"styleIncludePaths": ["../assets", "./assets"]
1616
}
1717
}
1818
}

src/lib/deprecations.ts

Lines changed: 0 additions & 173 deletions
This file was deleted.

src/lib/ng-package-format/entry-point.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,7 @@ export class NgEntryPoint {
104104
}
105105

106106
public get styleIncludePaths(): string[] {
107-
// lib.sassIncludePaths retained for backwards compatability
108-
const includePaths = this.$get('lib.styleIncludePaths') || this.$get('lib.sassIncludePaths') || [];
107+
const includePaths = this.$get('lib.styleIncludePaths') || [];
109108
return includePaths.map(
110109
includePath => (path.isAbsolute(includePath) ? includePath : path.resolve(this.basePath, includePath))
111110
);

src/lib/ng-package-format/package.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -61,13 +61,6 @@ export class NgPackage {
6161
return this.absolutePathFromPrimary('dest');
6262
}
6363

64-
/** Absolute path of the package's working directory (used for intermediate file storage).
65-
* @deprecated This is unused and will be removed in the next major version
66-
*/
67-
public get workingDirectory(): DirectoryPath {
68-
return this.absolutePathFromPrimary('workingDirectory');
69-
}
70-
7164
public get keepLifecycleScripts(): boolean {
7265
return this.primary.$get('keepLifecycleScripts') === true;
7366
}

src/ng-package.schema.json

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -74,13 +74,6 @@
7474
"enum": ["none", "inline"],
7575
"default": "none"
7676
},
77-
"sassIncludePaths": {
78-
"description": "DEPRECATED: Please use styleIncludePaths. sassIncludePaths will be removed in v3!",
79-
"type": "array",
80-
"items": {
81-
"type": "string"
82-
}
83-
},
8477
"styleIncludePaths": {
8578
"description": "Any additional paths that should be used to resolve style imports",
8679
"type": "array",

src/public_api.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,3 @@ export {
2323
} from './lib/ts/ng-component-transformer';
2424
export { isComponentDecorator, isStyleUrls, isTemplateUrl } from './lib/ts/ng-ts-ast';
2525
export { ComponentTransformer, transformComponent } from './lib/ts/transform-component';
26-
27-
/**
28-
* Deprecations that are going to be removed in v3.
29-
*/
30-
export * from './lib/deprecations';

0 commit comments

Comments
 (0)