Taking screenshots on Windows messes up view angle #18

Closed
motorsep opened this Issue Jul 5, 2012 · 23 comments

Comments

4 participants

motorsep commented Jul 5, 2012

When taking a screenshot on Windows with F12, the view turns left and centers.

Clean install of Doom 3, yesterday's git checkout, Windows XP 32bit.

Owner

dhewg commented Jul 20, 2012

For the record, this also happens with SDL2.

so, where is the issue and is it fixable ? :)

Shall we close this issue or is there a solution? :)

Contributor

andre-d commented Jul 27, 2012

I keep forgetting to look into this, I will add it to my list.

Owner

dhewg commented Jul 27, 2012

Yeah, don't just close it.
If anyone beat me, great. I just didn't had the motivation to hunt this win32 specific bug down :P

cool stuff, thanks guys :)

Contributor

andre-d commented Jul 27, 2012

Oh, windows specific? Ehhhhh, I will have a look at the code but cant test for that.

yeah, it only happens on Windows (can't test OS X)

and I will test it for you as soon as you can give me patch ! :)

motorsep commented Aug 1, 2012

No luck with this issue yet ?

Contributor

andre-d commented Aug 1, 2012

I have a hunch about it, when I hit F12 the cursor becomes visible.

motorsep commented Aug 1, 2012

well, it becomes visible on Linux too, but on Linux view doesn't move like on Windows

Contributor

andre-d commented Aug 1, 2012

Basically its an SDL bug that unhiding the cursor is causing a movement event (IMO).

motorsep commented Aug 1, 2012

why wouldn't it move the view on Linux ?

Contributor

andre-d commented Aug 1, 2012

Because SDL has different code on X11 than on windows.

motorsep commented Aug 1, 2012

ahh, gotcha. Well, if you have a patch, I can test it.

Contributor

andre-d commented Aug 1, 2012

Not exactly, the best solution would be to correct the functionality in SDL imo.

motorsep commented Aug 1, 2012

hmm.. DarkPlaces uses SDL 1.2.14 and has no issues with screenshots. Btw, I am not using dhewm3 builds with SDL2, I am using a build prior to that. So I am not convinced it's SDL's issue.

Contributor

andre-d commented Aug 2, 2012

Darkplaces likely doesnt show/hide the cursor while a screenshot is taken. If you want to work around the bug you can dig into whatever is hiding the cursor and change that.

motorsep commented Aug 2, 2012

So basically you are saying the issue is not solvable in the engine?

Contributor

andre-d commented Aug 2, 2012

I am saying it is solvable by a workaround.

motorsep commented Aug 2, 2012

ahh, ok. So, would you be able to make workaround patch by any chance, please? :)

Member

DanielGibson commented Aug 29, 2012

see #40

@DanielGibson DanielGibson added a commit to DanielGibson/dhewm3 that referenced this issue Oct 6, 2012

@DanielGibson DanielGibson Don't un-grab mouse when taking screenshots (fixes #18)
On windows un-grabbing (or possibly re-grabbing) the mouse seems to
mess up the view angly (view is centered afterwards), see
dhewm#18
That's fixed by not releasing the mouse (there is no reason to do that
anyway).
168d833
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment