r_aspectRatio -1 crashes the engine when trying to connect to a server

[motorsep]

Was trying to test multiplayer again yesterday, and got this:

assertion fail!
Game_local.cpp
Line 2767
Expression ( fov_x > 0 ) && ( fov_y > 0)

Windows 7 Pro 64bit (I recall the other guy had Linux)

setting r_aspectRatio to any other available value solves the crash, but doesn't solve having autodetection of aspect ratio working.

[DanielGibson]

I'll try to reproduce that later.
Was this in windowed or fullscreen mode? what resolution?

On Tue, May 14, 2013 at 11:39 PM, motorsep notifications@github.com wrote:

Was trying to test multiplayer again yesterday, and got this:

assertion fail!
Game_local.cpp
Line 2767
Expression ( fov_x > 0 ) && ( fov_y > 0)

Windows 7 Pro 64bit (I recall the other guy had Linux)

setting r_aspectRatio to any other available value solves the crash, but
doesn't solve having autodetection of aspect ratio working.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/70
.

[motorsep]

windowed mode, 1280x720

[DanielGibson]

This seems to be a known bug, see

dhewm3/neo/game/Game_local.cpp

Line 2428 in fe0ee16

// FIXME: somehow, this is happening occasionally

(that comment is from the originally released source)

If I find some time and motivation I'll try to investigate it further

[motorsep]

Thanks

[DanielGibson]

Please replace idGameLocal::CalcFov() from neo/game/Game_local.cpp with https://gist.github.com/DanielGibson/5595590 and post the output.
Ideally you run a debug build in a debugger and also post a stacktrace

[DanielGibson]

Any news?

[motorsep]

No, not yet.. I am not sure whether it was game code causing it or something else. Still under investigation.

[Wintch]

You can check my horrible solution here:
https://github.com/Wintch/dhewm3/blob/master/neo/game/Game_local.cpp
I had this problem with dedicated server (lacks FOV at all, so assert pops up)

[DanielGibson]

did you try https://gist.github.com/DanielGibson/5595590 to get some more infos?

I haven't looked into this issue in years because the original reporter failed to deliver more information..

[Wintch]

I can test it, no problem. my code is just dhewm3's fork with minor changes, so it is still a valid environment.
Spawn dedicated server, join the game, dedicated output:

ratio_x = 0.000000, ratio_y = 0.000000

drapded: /home/me/drap/dhewm3/trunk/neo/game/Game_local.cpp:2424: void idGameLocal::CalcFov(float, float&, float&) const: Assertion `ratio_x > 0 && ratio_y > 0' failed.
Aborted

[DanielGibson]

I couldn't reproduce this.. but I added a workaround for the case that ratio_x or ratio_y is 0 anyway.
Please reopen if you still get this crash with the latest code.