Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#28 refactor method missing #32

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

#28 refactor method missing #32

wants to merge 6 commits into from

Conversation

aaronmallen
Copy link
Contributor

Changed

  • Override Esi::Client.respond_to? to include
    Esi::Calls
  • Override Esi::Response.respond_to? to pass the method
    to data

Deprecated

  • Esi::Client#method?
  • Esi::Client#plural_method?

see #28

@aaronmallen aaronmallen added this to the v0.4.X milestone May 29, 2018
@aaronmallen
Copy link
Contributor Author

The new issue being reported by codeclimate will be resolved with #29

@aaronmallen aaronmallen changed the title 28 refactor method missing #28 refactor method missing May 29, 2018
@aaronmallen
Copy link
Contributor Author

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhiemstra dhiemstra Awaiting requested review from dhiemstra

Assignees

@dhiemstra dhiemstra

Labels
pr-build-passing pr-pending-review refactor tech-debt
Projects
None yet
Milestone
v0.4.X
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronmallen @dhiemstra