fix(deps): use exact version of workbox to avoid broken 6.6.1 version #843
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: tested this out on alpha, and it's not successful because
react-scripts
still has a dependency onworkbox-webpack-plugin@^6.4.1
, which resolves to the broken 6.6.1 upon installation of the CLICurrently, new installations of
cli-app-scripts
end up throwing an error on Node 14:This seems to be due to a broken release of
workbox
that should have been a major version, but it gets installed because of the ^6 dependency in the platformThe 6.6.1 release is now flagged as
deprecated
when installed on Node 16, and seems to be removed from the release history, which also shows the next major release as having the exact same breaking change in question (v7: Node 16 is now the minimum version). There is also a reported bugThis will avoid increasing the minimum Node requirement to 16 for app-platform