fix(deps): remove cli-app-scripts peer dep [LIBS-587] #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kabaros
approved these changes
Apr 9, 2024
dhis2-bot
added a commit
that referenced
this pull request
Apr 9, 2024
## [3.10.4](v3.10.3...v3.10.4) (2024-04-09) ### Bug Fixes * **deps:** remove cli-app-scripts peer dep [LIBS-587] ([#1379](#1379)) ([3598375](3598375))
|
🎉 This PR is included in version 3.10.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of LIBS-587
Tested out on
alpha, this addresses an module resolution conflict oncli-app-scriptsand fixes an infinite loop during NPM installation of the CLI.It seems like this dependency was introduced here, which I don't think was exactly correct -- App runtime doesn’t need cli-app-scripts to work, since it can be implemented independently using the
Provider— the app adapter just breaks if it doesn’t adapt to the app-runtime changes, which seems like a typical “breaking change” rather than needing a peer dependencyThis PR is to the main branch to save some PRs in the future --
@dhis2/uiwould need to be changed to use thealphabranch ofapp-runtimefor example, anduiseems to have the prerelease branches in use