fix: [DHIS2-17854] validate the assigned values from rules engine

[simonadomnisoru]

DHIS2-17854

Tech summary

• extracted the validateField logic from the FormBuilder.component into an external file.
• added a function, validateAssignEffects, that also calls validateField. The common function runs every time the rules engine finishes executing and before the assigned values are stored in Redux. To improve performance, only the last assigned value is validated, since it is the one stored in the redux formsValues key.
• switchMap, from() and of() were used in the epics to handle the async validation checks
• to prevent the user from clicking save/complete while an async validation is running:
  • In forms that rely on withSaveHandler.js, depending on the form logic, the actions startLoadDataEntry, startRunRulesPostUpdateField, and startRunRulesPostLoadDataEntry will be dispatched before running the validations. These actions will add an entry in dataEntriesInProgressList that will show the waitForPromisesDialogOpen modal if necessary.
  • In the WidgetProfile that does not rely on withSaveHandler.js, the Save button will be disabled

[github-actions]

🚀 Deployed on https://deploy-preview-3783--dhis2-capture.netlify.app

[JoakimSM]

I have made a few structural suggestions that I hope is reasonable. Open to discuss if you disagree of course.

I'm also wondering, since we are dealing with potential async validations here, what are we doing to prevent the user from clicking save/complete while an async validation is running? I couldn't see this being handled properly, but I very much might have missed something.

[JoakimSM]

Can we move this file to capture-core/utils/validation (new directory) and rename to validateValue.js (and update the function to validateValue). You will also have to move getValidators.js etc.

In addition, move capture-core/utils/validators into the folder created above (capture-core/utils/validation/validators...)

[JoakimSM]

Can we change the input here to only be the validators and not use object destructering.

[JoakimSM]

Hard to find a good name for this one (onIsValidatingInternal). Can we change the name of this callback to postProcessAsyncValidatonInitiation? Quite a mouthful, I know, but would like to have something a bit more describing.

[JoakimSM]

Can we move this file to capture-core/rules?

[simonadomnisoru]

I have made a few structural suggestions that I hope is reasonable. Open to discuss if you disagree of course.

I'm also wondering, since we are dealing with potential async validations here, what are we doing to prevent the user from > clicking save/complete while an async validation is running? I couldn't see this being handled properly, but I very much > might have missed something.

Hi @JoakimSM, I implemented the suggested structural changes.
Regarding preventing the user from clicking save/complete while an async validation is running, in withSaveHandler.js there is already logic for this handled by the waitForPromisesDialogOpen modal. There were only a few forms where the actions to enable/disable the waitForPromisesDialogOpen modal were missing and I added them. For WdigetProfile, the only form that does not rely on withSaveHandler.js, I added logic to disable/enable the Save button.

Can you have a look? Thank you!