Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [DHIS2-17874] replace remaining Material UI components #3794

Merged

Conversation

henrikmv
Copy link
Contributor

@henrikmv henrikmv commented Sep 9, 2024

DHIS2-17874

  • Removes MUI: SnackBar, MenuList, MenuItem, Grow, IconButton, Paper, Popover, Icons, createSvgIcon.
  • Uses the dhis2/ui DropdownButton to simplify the code.
  • Implements style changes to filter buttons to match the chevron in dhis2/ui DropdownButton

Note: The code in this PR is sourced from PR #3766, which was closed due to a commit message error. The changes have been migrated to this PR.

@henrikmv henrikmv marked this pull request as ready for review September 9, 2024 06:39
@henrikmv henrikmv requested a review from a team as a code owner September 9, 2024 06:39
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 😄

Copy link

github-actions bot commented Sep 10, 2024

@henrikmv
Copy link
Contributor Author

@eirikhaugstulen, a while ago you requested to change to IconButton from capture-ui, and add animation so it corresponds to similar components. It was a good suggestion, so I have tried to implement it now. Would you please take a review?

Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.42 version

@henrikmv henrikmv added testing and removed testing labels Oct 3, 2024
@henrikmv henrikmv merged commit 7194e54 into master Oct 3, 2024
39 checks passed
@henrikmv henrikmv deleted the hv/feat/DHIS2-17874_ReplaceRemainingMaterialuiComponents branch October 3, 2024 11:39
dhis2-bot added a commit that referenced this pull request Oct 3, 2024
# [101.7.0](v101.6.2...v101.7.0) (2024-10-03)

### Features

* [DHIS2-17874] replace remaining Material UI components ([#3794](#3794)) ([7194e54](7194e54))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 101.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants