feat: add validations for dhis2 package.json files (#47)

* feat: add validations for dhis2 package.json files

* fix: clean up code a bit

* fix: only do husky checks on root packages

* feat: add fine-grained style setup

* feat: check for publish access and autofix if possible

* chore: run pkg check

* refactor: minimize the amount of json parsing

* refactor: format json when writing

* chore: trigger apply

* feat: add validate command

* fix: do not add publish config to root dir

* refactor: remove package subcommand

* fix: use specific options for validation

* refactor: add space where needed

* refactor: add groups directory

* refactor: use the groups directory for config

* refactor: add all to the groups

* refactor: use singular for consistency

* refactor: use force to overwrite configs

Author: varl

.commitlintrc.js

@@ -0,0 +1,3 @@
+module.exports = {
+    extends: ['@commitlint/config-conventional'],
+}

.dependabot/config.yml

@@ -0,0 +1,18 @@
+version: 1
+
+update_configs:
+  - package_manager: "javascript"
+    directory: "/"
+    update_schedule: "live"
+    default_assignees:
+      - @dhis2/front-end
+    version_requirement_updates: "increase_versions"
+  - package_manager: "java:maven"
+    directory: "/"
+    update_schedule: "monthly"
+  - package_manager: "docker"
+    directory: "/"
+    update_schedule: "weekly"
+  - package_manager: "submodules"
+    directory: "/"
+    update_schedule: "weekly"

config/eslint.config.js renamed to .eslintrc.js

@@ -0,0 +1,18 @@
+version: 1
+
+update_configs:
+  - package_manager: "javascript"
+    directory: "/"
+    update_schedule: "live"
+    default_assignees:
+      - @dhis2/front-end
+    version_requirement_updates: "increase_versions"
+  - package_manager: "java:maven"
+    directory: "/"
+    update_schedule: "monthly"
+  - package_manager: "docker"
+    directory: "/"
+    update_schedule: "weekly"
+  - package_manager: "submodules"
+    directory: "/"
+    update_schedule: "weekly"

config/github/dependabot.yml

@@ -0,0 +1 @@
+_extends: .github

config/github/stale.yml

@@ -0,0 +1,39 @@
+const SEVERITY = 2
+
+module.exports = {
+    root: true,
+
+    parser: 'babel-eslint',
+
+    env: {
+        browser: true,
+        node: true,
+        jest: true,
+    },
+
+    parserOptions: {
+        // latest standard is ok, eq. to 9
+        ecmaVersion: 2018,
+        ecmaFeatures: {
+            jsx: true,
+            modules: true,
+        },
+    },
+
+    rules: {
+        'max-params': [
+            SEVERITY,
+            {
+                max: 3,
+            },
+        ],
+        'prefer-const': [
+            SEVERITY,
+            {
+                destructuring: 'any',
+                ignoreReadBeforeAssign: false,
+            },
+        ],
+        'no-mixed-spaces-and-tabs': [SEVERITY],
+    },
+}

config/browserslist.config.rc renamed to config/js/browserslist.config.rc

@@ -19,9 +19,12 @@
     "@commitlint/read": "^7.6.0",
     "@dhis2/cli-helpers-engine": "1.2.1",
     "babel-eslint": "^10.0.1",
+    "chalk": "^2.4.2",
     "eslint": "^5.16.0",
+    "fs-extra": "^8.0.1",
     "perfy": "^1.1.5",
     "prettier": "^1.15.3",
+    "semver": "^6.0.0",
     "yargs": "^13.1.0"
   },
   "devDependencies": {
@@ -30,7 +33,10 @@
   "husky": {
     "hooks": {
       "commit-msg": "./bin/d2-style commit check",
-      "pre-commit": "./bin/d2-style js apply"
+      "pre-commit": "./bin/d2-style validate js package --fix"
     }
+  },
+  "publishConfig": {
+    "access": "public"
   }
 }

config/js/eslint.config.js

@@ -38,6 +38,9 @@ exports.handler = argv => {
     report.summarize()
 
     if (report.hasViolations) {
+        log.error(
+            `${report.violations.length} file(s) violate the code standard.`
+        )
         process.exit(1)
     }