Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: port scheduler app to app platform #23

Merged
merged 163 commits into from
Feb 18, 2021
Merged

refactor: port scheduler app to app platform #23

merged 163 commits into from
Feb 18, 2021

Conversation

ismay
Copy link
Contributor

@ismay ismay commented Jun 21, 2019 •
edited
Loading

@ismay ismay mentioned this pull request Jun 21, 2019
Closed
@ismay ismay force-pushed the refactor-scheduler branch 4 times, most recently from 400a7c4 to d768d2f Compare July 2, 2019 10:30
@ismay ismay force-pushed the refactor-scheduler branch 6 times, most recently from a8fd1bd to ad847b2 Compare July 11, 2019 08:31
@ismay ismay force-pushed the refactor-scheduler branch 3 times, most recently from 5f74a21 to c76e1fa Compare July 18, 2019 15:24
@ismay ismay force-pushed the refactor-scheduler branch 2 times, most recently from 36a2a05 to 3bedb9b Compare July 24, 2019 11:49
@ismay ismay changed the title Refactor scheduler app refactor: improve scheduler app maintainability Sep 13, 2019
@stale stale bot added stale and removed stale labels Dec 12, 2019
@varl varl mentioned this pull request Jan 8, 2020
Closed
9 tasks
@ismay ismay mentioned this pull request Feb 20, 2020
Merged
@ismay ismay mentioned this pull request Mar 23, 2020
Merged
1 task
@dhis2 dhis2 deleted a comment from stale bot Mar 25, 2020
@ismay ismay force-pushed the refactor-scheduler branch 3 times, most recently from a0a521b to b080aeb Compare July 28, 2020 13:12
@ismay ismay changed the title refactor: improve scheduler app maintainability refactor: modernize scheduler app Jul 28, 2020
@ismay
Copy link
Contributor Author

ismay commented Feb 18, 2021 •
edited
Loading

Sounds good to me. I don't see a way to work around those issues with the current semi-dynamic strategy

Yeah exactly, me neither. I've created an issue for the unclear error message(s) here: https://jira.dhis2.org/browse/DHIS2-10521

HendrikThePendric
HendrikThePendric approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@HendrikThePendric HendrikThePendric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is looking super clean 👍

ismay added 23 commits February 18, 2021 16:02
test(translations): ensure all text is translated
bd0fe8f
fix(loading): render spinners without text when loading
3f0f1fc
feat(info): add info link for job listing
f5dd103
fix(translations): add translations for skip table types
e10f318
chore(npm-scripts): add test watch script
f062d89
fix(unauthorized): show noticebox for unauthorized users
c75df2c
refactor(edit): update edit form according to design
22b176d
fix(details): make details more independent from specific use
96a1c72
refactor(jobtable): extract job table from joblist route for clarity
15580a7
refactor(jobstore): move data queries up whilst we don't have caching
52f48c0
test: add remaining tests
3257d37
refactor(data-fetching): use a single store
6c413d8
test(store): add test for store
834fe5a
chore(translations): improve translations
4321dab
fix(useeffect): cleanup subscriber
3c223ad
fix(editform): replace query with store
25f8a27
fix(jobs-toggle-label): use better toggle description
6947d6a
fix(include-system-jobs): use checkbox for include system jobs switch
381a24e
fix(include-system-jobs): improve system jobs toggle label
a9ba272
test(list-jobs): add feature files
3bbbcb6
test(add-job): add feature files
890d9a9
test(edit-job): add feature files
baaa5f9
test(cypress): fix duplicate background step in feature file
4bf5a18
@ismay ismay merged commit 23ebb99 into master Feb 18, 2021
@ismay ismay deleted the refactor-scheduler branch February 18, 2021 15:09
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HendrikThePendric HendrikThePendric HendrikThePendric approved these changes

@Mohammer5 Mohammer5 Mohammer5 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ismay @Mohammer5 @dhis2-bot @HendrikThePendric