feat(org unit tree): allow node label customization (LIBS-203) #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mohammer5
force-pushed
the
LIBS-203_Org_unit_tree_leaf_label_customization
branch
from
8318631
to
db982fe
Compare
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Mohammer5
force-pushed
the
LIBS-203_Org_unit_tree_leaf_label_customization
branch
from
db982fe
to
1712a03
Compare
mediremi
reviewed
Jul 29, 2021
components/organisation-unit-tree/src/__e2e__/displaying_loading_error.stories.e2e.js
Outdated
Show resolved
Hide resolved
mediremi
reviewed
Jul 29, 2021
components/organisation-unit-tree/src/features/path_based_filtering/index.js
Outdated
Show resolved
Hide resolved
mediremi
reviewed
Jul 29, 2021
...s/organisation-unit-tree/src/organisation-unit-tree/default-render-node-label/label/label.js
Outdated
Show resolved
Hide resolved
mediremi
reviewed
Jul 29, 2021
...s/organisation-unit-tree/src/organisation-unit-tree/default-render-node-label/label/label.js
Outdated
Show resolved
Hide resolved
mediremi
reviewed
Jul 29, 2021
...isation-unit-tree/src/organisation-unit-tree/use-root-org-data/patch-missing-display-name.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Médi-Rémi Hashim <4295266+mediremi@users.noreply.github.com>
Co-authored-by: Médi-Rémi Hashim <4295266+mediremi@users.noreply.github.com>
Mohammer5
force-pushed
the
LIBS-203_Org_unit_tree_leaf_label_customization
branch
from
5aa4fdc
to
399375e
Compare
Mohammer5
force-pushed
the
LIBS-203_Org_unit_tree_leaf_label_customization
branch
from
15a4024
to
3b7cdb1
Compare
mediremi
reviewed
Aug 3, 2021
components/organisation-unit-tree/src/helpers/is-path-included.js
Outdated
Show resolved
Hide resolved
mediremi
reviewed
Aug 3, 2021
components/organisation-unit-tree/src/helpers/sort-node-children-alphabetically.js
Outdated
Show resolved
Hide resolved
mediremi
reviewed
Aug 3, 2021
components/organisation-unit-tree/src/organisation-unit-node/use-org-data/use-org-data.js
Outdated
Show resolved
Hide resolved
mediremi
reviewed
Aug 3, 2021
...s/organisation-unit-tree/src/organisation-unit-tree/default-render-node-label/label/label.js
Outdated
Show resolved
Hide resolved
mediremi
reviewed
Aug 3, 2021
components/organisation-unit-tree/src/organisation-unit-tree/organisation-unit-tree.js
Show resolved
Hide resolved
mediremi
approved these changes
Aug 6, 2021
dhis2-bot
added a commit
that referenced
this pull request
Aug 6, 2021
# [6.13.0](v6.12.0...v6.13.0) (2021-08-06) ### Features * **org unit tree:** allow node label customization (LIBS-203) ([#679](#679)) ([394010d](394010d))
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've exposed a
renderNodeLabelprop which can be used to customize the rendering.The object passed to that function contains several state information as well as info about the node.
Additionally that object has a
labelproperty which is what the internalLabelcomponent will render.That prop defaults to the display name.
I've created a story to highlight how it's supposed to work