Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use react-docgen #688

Merged
merged 3 commits into from
Aug 9, 2021
Merged

docs: use react-docgen #688

merged 3 commits into from
Aug 9, 2021

Conversation

mediremi
Copy link
Contributor

@mediremi mediremi commented Aug 9, 2021

This PR:

  1. Fixes generation of our documentation which was previously broken due to babel issues
  2. Uses react-docgen to generate better component documentation

@cypress
Copy link

cypress bot commented Aug 9, 2021



Test summary

512 0 0 0


Run details

Project ui
Status Passed
Commit 9c18e36
Started Aug 9, 2021 5:27 PM
Ended Aug 9, 2021 5:41 PM
Duration 13:53 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mediremi mediremi marked this pull request as draft August 9, 2021 17:30
@mediremi mediremi marked this pull request as ready for review August 9, 2021 17:34
Copy link
Contributor

@KaiVandivier KaiVandivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mediremi mediremi enabled auto-merge (squash) August 9, 2021 17:48
@mediremi mediremi merged commit 3d1ee61 into master Aug 9, 2021
@mediremi mediremi deleted the fix/docs branch August 9, 2021 18:02
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 6.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants