package/asset: Add extrinsic before dispatch #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shreevatsa N <vatsa@dhiway.com>
Signed-off-by: Shreevatsa N <vatsa@dhiway.com>
Signed-off-by: Amar Tumballi <amar@dhiway.com>
Signed-off-by: Shreevatsa N <vatsa@dhiway.com>
Signed-off-by: Shreevatsa N <vatsa@dhiway.com>
amarts
approved these changes
Mar 11, 2024
| let promises = []; | ||
| for (let j = 0; j < tx_batch.length; j++) { | ||
| try { | ||
| let extSignCallback: Cord.SignExtrinsicCallback = async ({ data }) => ({ |
There was a problem hiding this comment.
nitpick: This technically can move out of loop as this remains same regardless of iterations.
| const authorizedBatch = await Cord.Did.authorizeBatch({ | ||
| batchFunction: api.tx.utility.batchAll, | ||
| did: issuerDid.uri, | ||
| nonce: new BN(j+3), |
There was a problem hiding this comment.
This is needed mainly because of async submission. In a case where only 1 utility.batchAll() is called per block, we wouldn't need nonce calculations.
Leaving comment here for others to refer in future.
This was referenced Mar 28, 2024
Closed
Open
2 tasks
2 tasks
This was referenced Apr 25, 2024
This was referenced Sep 26, 2024
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
prepareExtrinsicbeforedispatchIssueToChain, making it possible to send batches of extrinsic calls in a single dispatch to chain call.