Improve scroll persistence #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows all buffer operations to be able to attempt to preserve scroll position without having to go through the Window object. Window.append should probably be deprecated, except perhaps as a convenience extension
This drastically simplifies the JLineBuffer implementation; we may even be able to just replace it with a factory function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have pretty solid scroll persistence when strictly appending, but I noticed it still gets wonky sometimes, and it turns out that's because we don't persist scroll position when deleting lines, etc. This PR refactors the way changes to the Buffer are passed onto the Renderer, by essentially having the Window subscribe to changes to the buffer.
JLineBuffernow does nothing on its own (we keep it around just in case we need some renderer-specific bits in there) and insteadJudoBuffernotifies any attachedIJudoWindowinstances that it's going to change something, and then that it has changed something, providing storage for the windows to save some state that they want handed back to them after the change.This allows
JLineWindowto trigger rendering when any change in anyJudoBuffersubclass occurs, and also to update its scroll position as necessary.