use bitstream-io for #4 #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a quick sanity check when switching from bitreader to bitstream-io.
This will make a bitreader->bitstream-io transition easier.
I also got rid of the infrequently-used read_{ue,se} methods in favor of
read_{ue,se}_named. The latter are newer and provide better diagnostics.
Because this is a breaking change, I bumped the version number and
added a change log.
Why?
* performance improvement to RbspBitReader as shown below (although
this is likely a small percentage of any useful program's time)
* switch from a less popular crate to a more popular crate
* be more consistent with adts-reader
* step toward the lazy RbspBufDecoder interface I described in #4
```
parse_nal/sps time: [511.27 ns 512.15 ns 513.01 ns]
change: [-17.150% -17.002% -16.853%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
3 (3.00%) high mild
1 (1.00%) high severe
```
Closed
|
Sorry for the mid-air collision there! 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.