Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates boxable official #142

Merged
merged 27 commits into from
Feb 1, 2018
Merged

Conversation

Frulenzo
Copy link
Collaborator

@dhorions Here are my cherry-picks with some bugfixes and new features. I'm a little bit in hurry so I will edit my post here when I come home.

Copy link
Owner

@dhorions dhorions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long, traveling this week.
This all looks very good and usefull, I especially like the html table rendering inside a cell.
I made a few very minor changes and think this can now be merged.
Let me know if you want to merge or if you want me to do that.
Once merged, I'll release this on Maven as 1.5

Thanks a lot!

@Frulenzo
Copy link
Collaborator Author

Frulenzo commented Feb 1, 2018

Yeah, you can merge it 👍 I can edit README maybe tomorrow with 1.5 changes and expand our wiki a little bit.

@dhorions
Copy link
Owner

dhorions commented Feb 1, 2018 via email

@dhorions dhorions merged commit 7cf6c97 into dhorions:master Feb 1, 2018
@dhorions
Copy link
Owner

dhorions commented Feb 7, 2018

Hi @Frulenzo , did you have a chance to update the readme yet?
I'd like to release the 1.5 version to maven when you did that.

@Frulenzo
Copy link
Collaborator Author

Frulenzo commented Feb 7, 2018

I already have a small text for readme, I only need to make wiki entry about new changes and how to use them.

Today evening I can make readme update and over the weekend I will make a wiki entry 👍

@dhorions
Copy link
Owner

dhorions commented Feb 8, 2018

I released this to the central maven repository. I think I did everything correctly, but don't see it yet here, this may just take a while to update.

@dhorions
Copy link
Owner

dhorions commented Feb 8, 2018

Looks like the detail page exists, just the list of versions page is not yet updated.

https://search.maven.org/#artifactdetails%7Ccom.github.dhorions%7Cboxable%7C1.5%7Cjar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants