Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect large images for specified resolutions #49

Open
dhowe opened this issue Jan 9, 2022 · 18 comments
Open

Collect large images for specified resolutions #49

dhowe opened this issue Jan 9, 2022 · 18 comments
Assignees
Milestone

Comments

@dhowe
Copy link
Owner

dhowe commented Jan 9, 2022

Collect large climate images for the specified resolution ratios: 4:3, 3:4, 32:9, 9:32, 2:1, 1:2

Target min sizes:
4:3 -> 960x720
2:1 -> 1000x500
32:9 -> 1920x540

Name them with the credit for the photographer and the dimensions: e.g., 'ChristopherFurlong_GettyImages_960x720.png'

Then place them in the correct folder for the ratio:

image

@dhowe dhowe added this to the Climate milestone Jan 9, 2022
@dhowe dhowe self-assigned this Jan 9, 2022
@dhowe
Copy link
Owner Author

dhowe commented Jan 10, 2022

I have placed some images to start with in the 'unclassified' folder (shown above):

  • calculate the resolution ratio
  • can adjust slightly (<10%) via cropping
  • update the image name with file size (see above)
  • move the image inside the correct folder for its ratio (or to 'nomatch' if none)

If the image is not already tagged with a credit, do a quick search for the image name online. If still not found, append '_nc' (for 'needs credit') to its name

@dhowe dhowe changed the title [Climate ]Collect climate large images according to specified resolutions [Climate ] Collect large images for specified resolutions Jan 10, 2022
@dhowe dhowe removed their assignment Jan 10, 2022
@Real-John-Cheung
Copy link
Collaborator

I just sync this branch with main and update the folder name "2x3" and "3x2" to "4x3" and "3x4"
@StevenZhou01 just in case, please pull when you start classify the images...

@dhowe dhowe changed the title [Climate ] Collect large images for specified resolutions Collect large images for specified resolutions Jan 12, 2022
@dhowe
Copy link
Owner Author

dhowe commented Jan 25, 2022

@StevenZhou01 status of this?

@StevenZhou01
Copy link
Collaborator

I am done the organizing work on last Sunday. Currently, since "3x2" and "2x3" were changed to "4x3" and "3x4", the photos with "3x2" or "2x3" ratios are put in "nomatch" file. Other photos in "nomatch" file are either in different ratios or hard to be cropped or adjusted. If more photos are needed, please let me know.

@dhowe
Copy link
Owner Author

dhowe commented Jan 25, 2022

If you run out of other tickets, you can continue with images here. Please pay attention to how well they work with text overlayed.

@dhowe
Copy link
Owner Author

dhowe commented Jan 25, 2022

note also that you can search via google for general aspect ratios of images, by using 'advanced image search': https://www.google.co.uk/advanced_image_search

image

@Real-John-Cheung
Copy link
Collaborator

Real-John-Cheung commented Jan 26, 2022

One more thing...
if possible, convert all images to jpg or png format before adding them. formats like webp might cause issues on chrome
Thx!

Edit------------------------------------
also no jpeg, and pls also avoid special characters like : and (space) in the file name if possible

@StevenZhou01
Copy link
Collaborator

Okay! I will convert the old photos into the suitable formats.

@Real-John-Cheung
Copy link
Collaborator

During testing I noticed that some images like JamesBalog6_1120x700.jpeg have pure color backgrounds, not sure if it is intended.

@dhowe
Copy link
Owner Author

dhowe commented Jan 29, 2022

Needs to be cropped

@StevenZhou01
Copy link
Collaborator

StevenZhou01 commented Jan 29, 2022

Should I crop them now or later?
I mean for categorizing photos

@dhowe
Copy link
Owner Author

dhowe commented Jan 30, 2022

how many photos have borders like this? should be very infrequent...
if < 10, can crop now

@StevenZhou01
Copy link
Collaborator

Yes it's not. Then I will crop it.

This was referenced Feb 2, 2022
@StevenZhou01
Copy link
Collaborator

There is one thing that needs to notice. Some photos may have a very strict copyright policy, such as those from the National Geographic. Although you can download them from google, the website actually blocks you to download them if you click on the website.

StevenZhou01 added a commit that referenced this issue Feb 3, 2022
fix to #49, add 8 new images to 1x2 file
@Real-John-Cheung
Copy link
Collaborator

@StevenZhou01 hey Steven, when adding images in the future, use x (the 24th letter) instead of × (/u00D7) in the file name. You can use this regex to check /([A-Za-z_0-9-]+\.(png|jpg))/, thanks

@StevenZhou01
Copy link
Collaborator

@StevenZhou01 hey Steven, when adding images in the future, use x (the 24th letter) instead of × (/u00D7) in the file name. You can use this regex to check /([A-Za-z_0-9-]+\.(png|jpg))/, thanks

Okay, will do!

StevenZhou01 added a commit that referenced this issue Feb 7, 2022
Fix to #49, 8 images to 9x32
StevenZhou01 added a commit that referenced this issue Feb 7, 2022
Fix to #49, 8 images to 9x32 file
This was referenced Feb 7, 2022
@StevenZhou01
Copy link
Collaborator

Now each folder should have some photos, but generally 9x32 photos are fewer and harder to find on the internet.

@dhowe
Copy link
Owner Author

dhowe commented Feb 10, 2022

thanks, lets put this on hold for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants