Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads not collected on Reddit.com #2344

Open
GlogGlog opened this issue Jun 26, 2023 · 6 comments
Open

Ads not collected on Reddit.com #2344

GlogGlog opened this issue Jun 26, 2023 · 6 comments

Comments

@GlogGlog
Copy link

[Tried new profile, no change]
Fresh install, at first on my usual profile and then on a new one. The adblocker is effective, some ads are collected but not when I want them to be (i.e. youtube.com, amazon.com...). uBlock shows how many ads are being blocked but AdNauseam doesn't seem to detect them.

Steps for anyone to reproduce the issue: just install AdNauseam
Screenshot 2023-06-26 alle 1 44 25 PM

Screenshot 2023-06-26 alle 1 43 55 PM

Your settings

  • OS/version: ventura 13.4
  • Browser/version: Firefox 114.0.2
  • AdNauseam version: 3.17.0
  • Other extensions you have installed [on main profile] (Enabled:) AdNauseam, Invidious redirect, Return to youtube dislike, watch on Odysee, YouTube-shorts block, (disabled:) NoScript, ublock origin, decentraleyes; [on new profile] AdNauseam.
  • AdNauseam settings:
Your filter lists

Haven't touched it

Your location/country

Italy

@verumIgnis
Copy link

I am having the same issue, I have nothing else blocking ads (when I disable adnauseam I get ads). I do have extra filters enabled and im using the latest version on firefox.

@verumIgnis
Copy link

After further testing I have also tried using windows (firefox and brave) and it still isnt working so it isnt a problem specific to linux.

@PollyMaker
Copy link

Been having this issue also on Firefox while using Windows. Even with the built-in protection settings disabled, it doesn't collect ads on most pages.

@mneunomne
Copy link
Collaborator

Ads not being collected on all websites is a thing we are constantly working on. Some ads we don't have a way to collect (yet...), others we have to create custom filter and allow certain specific rules so that they are collected.

Youtube for example, is a website that is very tricky to collect ads. We develop a solution to collect a specific type of ad, then a few months later they change their ad structure and we have to do that once again...

Amazon is a good point where ads seem collectable but aren't at the moment, we'll work on it.

@verumIgnis
Copy link

Is it AdNauseam/filters/adnauseam.txt that contains the rules to collect ads? I havent contributed before but I would happily make some rules for some sites.

@mneunomne mneunomne changed the title Ads not collected Ads not collected on Reddit.com Sep 18, 2023
@mneunomne
Copy link
Collaborator

Seems like the ads are detected by the parser but failed to be collected for not finding a link. Will check on this some other day again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants