-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with first-run html #784
Comments
https://github.com/dhowe/AdNauseam/blob/merged-1.9.16/src/js/i18n.js#L34 |
firstrun page calls vAPI.i18n.render() to rerender the text for the changing firstrun-button. |
alternatively we can change the i18n.js function, though we need to make sure any tags are safe (this is the underlying issue: gorhill#2084) |
For class/id issue, I think it is better to just remove them from locale, as same effect can be achieved by writing a different css selector. And the second issue is closely related to the core of this security issue: append instead of innerHTML. So I think it is better to leave the i18n.js unchanged and change the other. |
fixed #786 |
The text was updated successfully, but these errors were encountered: