Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Audio/Video from playing in pages clicked by the plugin #12

Closed
dhowe opened this issue Nov 2, 2013 · 14 comments
Closed

Block Audio/Video from playing in pages clicked by the plugin #12

dhowe opened this issue Nov 2, 2013 · 14 comments
Assignees
@dhowe
Labels
Bug Needs-test-case PRIORITY: Medium
Milestone
Version1.2

Comments

@dhowe
Copy link
Owner

dhowe commented Nov 2, 2013

Its annoying when ADN clicks a link in its hidden window, which then auto-starts video or audio. As the tab is not visible, the user can only mute the whole system, or restart Firefox.
@dhowe
Copy link
Owner Author

dhowe commented Jan 3, 2014

Currently we are attempting to cancel all requests that we identify as audio/video/itunes/etc, but this needs much more thought/work

@mushon
Copy link
Collaborator

mushon commented Jan 3, 2014

why not have js simply delete any embed / object / video / audio tag from the pages within the hidden iframes? Can this cascade into the iFrames within those hidden iFrames?

@mushon mushon mentioned this issue Jan 3, 2014
Closed
@dhowe
Copy link
Owner Author

dhowe commented Jan 5, 2014

"[W]hy not have js simply delete any embed / object / video / audio tag from the pages within the hidden iframes"?

Easier said than done I think... Do we have any example of a plugin that does this? Certainly there are flashblockers, but we've also talked about wanting 'grab' animated ads of different types for the adview... I'm currently using regexs to cancel these (sub)requests, but they simple/stupid at the moment, and things get through (clearly, see issue #16)...

@ghost ghost assigned dhowe Jan 5, 2014
@dhowe dhowe mentioned this issue Jan 8, 2014
Closed
@dhowe
Copy link
Owner Author

dhowe commented Jan 17, 2014

Log from a case where this occurred:

[23:16:51:383] TRYING: http://www.nytimes.com/adx/bin/adx_click.html?type=goto&opzn&page=www.nytimes.com/pages/realestate/index.html&pos=Box2&sn2=2f689ef3/3b4775dc&sn1=7441b9be/43ec397d&camp=inyt2013_120x90_digi_glob_3LUWH&ad=3LUWH_120x90_digi_glob&goto=http%3A%2F%2Fwww%2Einyt%2Ecom%2Fsubscriptions%2Finyt%2Flp3KYXX%2Ehtml%3Fadxc%3D232691%26adxa%3D359250%26page%3Dwww.nytimes.com/pages/realestate/index.html%26pos%3DBox2%26campaignId%3D3LUWH

[23:16:52:383] Cancelled(/video/i) -> http://www.inyt.com/subscriptions/inyt/img/icon-video.gif

[23:16:54:004] VISITED: http://www.inyt.com/subscriptions/inyt/lp3KYXX.html?adxc=232691&adxa=359250&page=www.nytimes.com/pages/realestate/index.html&pos=Box2&campaignId=3LUWH
Redirected-from: http://www.nytimes.com/adx/bin/adx_click.html?type=goto&opzn&page=www.nytimes.com/pages/realestate/index.html&pos=Box2&sn2=2f689ef3/3b4775dc&sn1=7441b9be/43ec397d&camp=inyt2013_120x90_digi_glob_3LUWH&ad=3LUWH_120x90_digi_glob&goto=http%3A%2F%2Fwww%2Einyt%2Ecom%2Fsubscriptions%2Finyt%2Flp3KYXX%2Ehtml%3Fadxc%3D232691%26adxa%3D359250%26page%3Dwww.nytimes.com/pages/realestate/index.html%26pos%3DBox2%26campaignId%3D3LUWH

[23:17:02:511] TRYING: http://www.nytimes.com/adx/bin/adx_click.html?type=goto&opzn&page=www.nytimes.com/pages/realestate/index.html&pos=Frame3B&sn2=ed3abcee/153b086d&sn1=21bb5873/37806ffb&camp=Urbana_Propertie_1862311_Broker_Button-cla&ad=urbana-120x90-Banner_g.gif&goto=http%3A%2F%2Fwww%2Eurbanaproperties%2Ecom%2F

[23:17:16:330] VISITED: http://urbanaproperties.com/
Redirected-from: http://www.nytimes.com/adx/bin/adx_click.html?type=goto&opzn&page=www.nytimes.com/pages/realestate/index.html&pos=Frame3B&sn2=ed3abcee/153b086d&sn1=21bb5873/37806ffb&camp=Urbana_Propertie_1862311_Broker_Button-cla&ad=urbana-120x90-Banner_g.gif&goto=http%3A%2F%2Fwww%2Eurbanaproperties%2Ecom%2F

[23:17:24:541] TRYING: http://www.nytimes.com/adx/bin/adx_click.html?type=goto&opzn&page=www.nytimes.com/pages/realestate/index.html&pos=Box1&sn2=2f689ef2/b4775dc&sn1=bff00d48/14532819&camp=nyt2014_300x250_module_chickenstew_hp_ros&ad=VI-D-I-NYT-MOD-MOD-M340D-ROS-0114&goto=http://nytimes.com/video/dining/100000002642899/chicken-stew-with-sweet-plantains.html%3FWT.mc_id=VI-D-I-NYT-MOD-MOD-M340D-ROS-0114-PH%26WT.mc_ev=click%26WT.mc_c=235247

[23:17:24:543] Cancelled(/video/i) -> http://www.nytimes.com/adx/bin/adx_click.html?type=goto&opzn&page=www.nytimes.com/pages/realestate/index.html&pos=Box1&sn2=2f689ef2/b4775dc&sn1=bff00d48/14532819&camp=nyt2014_300x250_module_chickenstew_hp_ros&ad=VI-D-I-NYT-MOD-MOD-M340D-ROS-0114&goto=http://nytimes.com/video/dining/100000002642899/chicken-stew-with-sweet-plantains.html%3FWT.mc_id=VI-D-I-NYT-MOD-MOD-M340D-ROS-0114-PH%26WT.mc_ev=click%26WT.mc_c=235247

@dhowe
Copy link
Owner Author

dhowe commented Sep 21, 2014

need a test-case for this

@dhowe
Copy link
Owner Author

dhowe commented Nov 3, 2014

This should be fixed (once and for all) by disallowing plugin permissions on the (click) page-worker

@dhowe dhowe closed this as completed Nov 3, 2014
@mushon
Copy link
Collaborator

mushon commented Nov 3, 2014

Cool, does your code also prevent html5 video and audio there?

@dhowe
Copy link
Owner Author

dhowe commented Nov 3, 2014

good point -- we'll have to test this...

@dhowe dhowe reopened this Nov 3, 2014
@dhowe
Copy link
Owner Author

dhowe commented Nov 23, 2014

closing for now, can re-open if we find another case

@dhowe dhowe closed this as completed Nov 23, 2014
@mushon
Copy link
Collaborator

mushon commented Dec 25, 2014

This ad played audio in the background (FF 33.1, ADN 1.0.05):

==========================================================================================
[5:49:31 PM:650] TEXT-AD: #890005 Ultimate Detangling Brush/www.MyNoTangleBrush.com/Michel Mercier's Brush Works On All Types of Hair! Now Get 2 for $14.95
==========================================================================================
[5:49:32 PM:639] TRYING(#890005): http://1641040.r.msn.com/?ld=d3ATGkt4INmPh1Lt1iaelT-TVUCUwdU9nR-MwkYaaapnosUbgsSfocyZqmMV6uyI0NXAkVddFhaRPfS9W93XQdxgHOwpXq6XpND3kswjd85uhwvezfnjAM9A-bRrZlJ9abZmkx7TWYOm-fHOZ6QulO4VqG0wU&u=https%3a%2f%2fwww.mynotanglebrush.com%2f%3fMID%3d6159551
==========================================================================================
[5:49:37 PM:771] VISITED(#890005): https://www.mynotanglebrush.com/?MID=6159551
               Redirected-from: http://1641040.r.msn.com/?ld=d3ATGkt4INmPh1Lt1iaelT-TVUCUwdU9nR-MwkYaaapnosUbgsSfocyZqmMV6uyI0NXAkVddFhaRPfS9W93XQdxgHOwpXq6XpND3kswjd85uhwvezfnjAM9A-bRrZlJ9abZmkx7TWYOm-fHOZ6QulO4VqG0wU&u=https%3a%2f%2fwww.mynotanglebrush.com%2f%3fMID%3d6159551
==========================================================================================```

@mushon mushon reopened this Dec 25, 2014
@dhowe dhowe added this to the Version1.2 milestone Jan 9, 2015
@dhowe
Copy link
Owner Author

dhowe commented Jan 15, 2015

Here's another case:
http://bellroy.com/wallets/travel-wallet?utm_source=Google&utm_medium=display&utm_campaign=Display%20|%20AU&gclid=CJaUoZSJlsMCFYcsvQod2jUAVA

Appears to be caused by 'jwplayer' triggering html5 video:

<div class="jwplayer aspectMode playlist-none jw-user-inactive" id="product-gallery-player" tabindex="0" style="width: 100%; display: inline-block; opacity: 1; background-color: rgb(0, 0, 0);">

@dhowe
Copy link
Owner Author

dhowe commented Jan 23, 2015

As is the one above (html5-video):
https://www.mynotanglebrush.com/?MID=6159551

<div id="video"><div id="video-video1199" class="video-js vjs-default-skin vjs-playing" width="290" height="215" style="width: 290px; height: 215px;">

@dhowe
Copy link
Owner Author

dhowe commented Jan 24, 2015

This can now be easily reproduced by loading/importing: lib/test/single-audio-test.json

dhowe added a commit that referenced this issue Jan 24, 2015
@dhowe
fix for #12 (again)
08f9f6b
@dhowe
Copy link
Owner Author

dhowe commented Jan 24, 2015

Fixed via a regular expression hack, should revisit this, but closing for now...

@dhowe dhowe closed this as completed Jan 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhowe dhowe

Labels
Bug Needs-test-case PRIORITY: Medium
Projects
None yet
Milestone
Version1.2
Development

No branches or pull requests
2 participants
@mushon @dhowe