Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect ads within iframes (and nested iframes) #200

Closed
CyrusSUEN opened this issue Jan 14, 2015 · 4 comments
Closed

Detect ads within iframes (and nested iframes) #200

CyrusSUEN opened this issue Jan 14, 2015 · 4 comments

Comments

@CyrusSUEN
Copy link
Collaborator

Ask.com text Ads inside iframe
http://www.ask.com/web?qsrc=1&o=0&l=dir&q=stock&qo=serpSearchTopBox

@dhowe
Copy link
Owner

dhowe commented May 1, 2015

This is critically important for the long run. We do already detect some ads in iframes, this page, for example. We need to now determine the structure of ads on the iframed pages where we are failing to recognize the ad.

Is it due to ...

  • cross-domain restrictions
  • iframes generated from javascript
  • multiple layers of nesting
  • no access to jquery in iframe
  • timing issues (selector is tested before items are ready)
  • some combination of the above

?

@dhowe dhowe changed the title Text-ads: Ask.com text Ads within iframe tag cannot be detected Detect ads within iframes (or nested iframes) May 1, 2015
@dhowe dhowe changed the title Detect ads within iframes (or nested iframes) Detect ads within iframes (and nested iframes) May 1, 2015
@dhowe
Copy link
Owner

dhowe commented May 6, 2015

TEST CASES

Blocking:

-- Simple iFrame OK
-- Crossdomain iFrame OK
-- Simple Nested iFrame OK
-- JS-Created iFrame OK
-- JS-Created Nested iFrames OK

Hiding:

-- Simple ElemHide OK
-- Simple ElemHide in iFrame FAIL!

@dhowe
Copy link
Owner

dhowe commented May 6, 2015

I have committed a fix to this -- please check it on the ads you have identified

@dhowe dhowe assigned dhowe and unassigned CyrusSUEN May 11, 2015
CyrusSUEN added a commit to CyrusSUEN/AdNauseam that referenced this issue May 15, 2015
@CyrusSUEN
Copy link
Collaborator Author

added rules for finding ask.com text ad
CyrusSUEN@dc3bf1d
URL for testing: http://www.ask.com/web?qsrc=1&o=0&l=dir&q=credit+cards&qo=serpSearchTopBox

But still cannot find text ad in ask.com for the moment

console.log: adnauseam: ELEMHIDE-HIT: .ad-top waiting-for -> .ad-top div.ad (ifr
ame: false, domain: www.ask.com) null
console.warn: adnauseam: *** [Cross-Domain IFRAME?] //www.google.com/afs/ads?q=c
redit%20cards&oe=utf-8&ie=utf-8&lo=false&adpage=1&adrep=5&po=true&r=m&fexp=21404
&client=aj-cat-intl&channel=business-finance%2Corig_serpSearchTopBox%2Cud_deskto
p&adtest=off&adsafe=medium&type=0&format=p5%7Cn5&ad=n5p5&nocache=121143170861043
4&num=0&output=uds_ads_only&v=3&adlh=on&adext=as1%2Csr1&bsl=10&u_his=4&u_tz=480&
dt=1431708610435&u_w=2560&u_h=1440&biw=1249&bih=1306&psw=1249&psh=1679&frm=0&uio
=uv3cs1sr1lo0po1va1hcsl1cc0-lHaf3st15sd13sv13sa13lt18ld17lv19da1-lhaf3st15sd13sv
13sa13lt18ld17lv19da1&rurl=http%3A%2F%2Fwww.ask.com%2Fweb%3Fqsrc%3D1%26o%3D0%26l
%3Ddir%26q%3Dcredit%2Bcards%26qo%3DserpSearchTopBox&referer=http%3A%2F%2Fwww.ask
.com%2Fweb%3Fq%3Dcredit%2Bcards%2Bfor%2Bpeople%2Bwith%2Bbad%2Bcredit%26qsrc%3D23
52%26qo%3DsearchSuggestions%26o%3D0%26l%3Ddir#master-1 (elem-hides ignored ***)
console.warn: adnauseam: *** [Cross-Domain IFRAME?] //www.google.com/afs/ads/i/i
frame.html#slave-1-1 (elem-hides ignored ***)
console.warn: adnauseam: *** [Cross-Domain IFRAME?] http://googleads.g.doublecli
ck.net/pagead/viewthroughconversion/1003219837/?random=1431708610404&cv=7&fst=14
31708610404&num=1&fmt=1&guid=ON&u_h=1440&u_w=2560&u_ah=1400&u_aw=2560&u_cd=24&u_
his=4&u_tz=480&u_java=true&u_nplug=15&u_nmime=68&frm=0&url=http%3A//www.ask.com/
web%3Fqsrc%3D1%26o%3D0%26l%3Ddir%26q%3Dcredit+cards%26qo%3DserpSearchTopBox&ref=
http%3A//www.ask.com/web%3Fq%3Dcredit+cards+for+people+with+bad+credit%26qsrc%3D
2352%26qo%3DsearchSuggestions%26o%3D0%26l%3Ddir&vis=1 (elem-hides ignored ***)
console.warn: adnauseam: *** [Cross-Domain IFRAME?] http://bcp.crwdcntrl.net/5/c
=4737/rand=629294752/pv=y/srch=%23OpR%2348906%23Ask%20%3A%20Search%20Term%20%3A%
20credit%20cards/rt=ifr (elem-hides ignored ***)

dhowe added a commit that referenced this issue May 15, 2015
fixed sogou text ad URL undefined error and added rules for ask text ad (#200)
@dhowe dhowe closed this as completed Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants