Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repeat behavior in Choice sequences #63

Closed
Real-John-Cheung opened this issue Sep 6, 2020 · 2 comments
Closed

Repeat behavior in Choice sequences #63

Real-John-Cheung opened this issue Sep 6, 2020 · 2 comments
Assignees
@dhowe
Labels
enhancement New feature or request question Further information is requested

Comments

@Real-John-Cheung
Copy link
Collaborator

In
src/visitor.js line382
@dhowe
Copy link
Owner

dhowe commented Sep 6, 2020 •
edited
Loading

no-repeat should be the default for choices -- to allow repeat add a new reps() transform to allow repeats (pure random)

@dhowe dhowe self-assigned this Sep 6, 2020
@dhowe dhowe changed the title class NoRepeat Repeat behavior in Choice sequences Sep 6, 2020
dhowe added a commit that referenced this issue Jan 8, 2021
@dhowe
implement #63
4d6364c
@dhowe dhowe added enhancement New feature or request question Further information is requested and removed priority: High labels Jan 8, 2021
@dhowe
Copy link
Owner

dhowe commented Jan 8, 2021 •
edited
Loading

this causes problems for weighted choices where the user WANTS the output with higher weight to repeat.
Options:

  1. leave as is
  2. use non-repeating only for those choices without any specified weights (perhaps confusing)

Note that this is implemented in the 'default-choice-random' branches in all 3 repos

@dhowe dhowe closed this as completed Jan 16, 2021
dhowe added a commit that referenced this issue Jan 29, 2021
@dhowe
work on #63
8ce9504
dhowe added a commit that referenced this issue Jan 29, 2021
@dhowe
fix to #63
8c19461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhowe dhowe

Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhowe @Real-John-Cheung