Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panning using space click and mouse click isn't working, fixed it #59

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

a-khushal
Copy link
Contributor

@a-khushal a-khushal commented May 19, 2024

after the introduction of panning using keyboard space click the delete button wan't working which was fixed by PR #46, but after this PR panning using space click isn't working.

how to reproduce the issue: try panning using space key and mouse click, it doesn't pan

Here's a ScreenCast showcasing the problem and the solution

Screencast.from.19-05-24.04.59.49.PM.IST.webm

The issue here is that the canvas isn't getting focused, so added tabIndex = 0 to the canvas object which fixes this issue

Copy link

vercel bot commented May 19, 2024

@a-khushal is attempting to deploy a commit to the dhruvpatidar359's projects Team on Vercel.

A member of the Team first needs to authorize it.

@a-khushal a-khushal changed the title Feature/pan using space key Panning using space click and mouse click isn't working, fixed it May 19, 2024
Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextdraw ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 2:56am

@dhruvpatidar359
Copy link
Owner

@a-khushal Hi , everything works greate , but there is one issue with the undo and redo , have a look :

ART-2024-05-20@03-27-38.809-1920x904@60fps.mp4

Both the text and the color disappear simultanously . This is because , these two changes are included in the same state , we have to create this in two different states .

@dhruvpatidar359 dhruvpatidar359 self-requested a review May 20, 2024 03:34
@dhruvpatidar359 dhruvpatidar359 added bug Something isn't working gssoc Issues / PR related to Gssoc'24 level1 Issues / PR related to Gssoc'24 difficulty easy labels May 20, 2024
@a-khushal
Copy link
Contributor Author

Alright, will work on it

@a-khushal
Copy link
Contributor Author

a-khushal commented Jun 6, 2024

@dhruvpatidar359 I have added layers to the same branch. Here's a screencast showing the working of layers
Screencast from 06-06-24 11:36:47 PM IST.webm

@a-khushal
Copy link
Contributor Author

a-khushal commented Jun 6, 2024

@dhruvpatidar359 I have added layers to the same branch. Here's a screencast showing the working of layers Screencast from 06-06-24 11:36:47 PM IST.webm

Now how do I get this PR assigned under GSSOC, it's level3 also, I have pushed to the same PR, haven't raised a new one.

@dhruvpatidar359
Copy link
Owner

@a-khushal I am impressed with this , just two things to consider more .
Please put this into another PR , not in the same PR . We have to track each individual PR separate .
second is there are some issues with the implementation .

Have a look : Again the Work is awesome .

20240607_083133.mp4

@a-khushal
Copy link
Contributor Author

@dhruvpatidar359 please refer #76 this solves layers and the above shown issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc Issues / PR related to Gssoc'24 level1 Issues / PR related to Gssoc'24 difficulty easy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants