-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panning using space click and mouse click isn't working, fixed it #59
base: master
Are you sure you want to change the base?
Panning using space click and mouse click isn't working, fixed it #59
Conversation
@a-khushal is attempting to deploy a commit to the dhruvpatidar359's projects Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@a-khushal Hi , everything works greate , but there is one issue with the undo and redo , have a look : ART-2024-05-20@03-27-38.809-1920x904@60fps.mp4Both the text and the color disappear simultanously . This is because , these two changes are included in the same state , we have to create this in two different states . |
Alright, will work on it |
…eature/pan-Using-Space-key
…ushal/nextdraw into feature/pan-Using-Space-key
@dhruvpatidar359 I have added layers to the same branch. Here's a screencast showing the working of layers |
Now how do I get this PR assigned under GSSOC, it's level3 also, I have pushed to the same PR, haven't raised a new one. |
@a-khushal I am impressed with this , just two things to consider more . Have a look : Again the Work is awesome . 20240607_083133.mp4 |
@dhruvpatidar359 please refer #76 this solves layers and the above shown issue |
after the introduction of panning using keyboard space click the delete button wan't working which was fixed by PR #46, but after this PR panning using space click isn't working.
how to reproduce the issue: try panning using space key and mouse click, it doesn't pan
Here's a ScreenCast showcasing the problem and the solution
Screencast.from.19-05-24.04.59.49.PM.IST.webm
The issue here is that the canvas isn't getting focused, so added tabIndex = 0 to the canvas object which fixes this issue