Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Details page broken if no SSH key passed #1

Closed
bluecmd opened this issue Nov 19, 2018 · 0 comments · Fixed by #2
Closed

Details page broken if no SSH key passed #1

bluecmd opened this issue Nov 19, 2018 · 0 comments · Fixed by #2
Labels
bug Something isn't working

Comments

@bluecmd
Copy link
Contributor

bluecmd commented Nov 19, 2018

If the request contains no ssh key the rendering of the status page breaks down causing the page to only display "Trying to talk to prodaccess to validate your login request ..." as no javascript has been loaded.
@bluecmd bluecmd added the bug Something isn't working label Nov 19, 2018
@ventris ventris mentioned this issue May 4, 2019
Merged
ventris added a commit that referenced this issue May 4, 2019
@ventris
Resolves silently failing requests without ssh-key
802aafa 
Wraps sshcertificate request in an if statement on authservice. Instead
of silently failing authservice returns that it will not sign any
ssh-keys.

This resolves #1
@ventris ventris closed this as completed in #2 May 4, 2019
ventris added a commit that referenced this issue May 4, 2019
@ventris
Resolves silently failing requests without ssh-key (#2)
e1a95c1 
Wraps sshcertificate request in an if statement on authservice. Instead
of silently failing authservice returns that it will not sign any
ssh-keys.

This resolves #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolves silently failing requests without ssh-key dhtech/authservice
1 participant
@bluecmd