Add option for specifying platform of docker image #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhui
requested changes
Feb 7, 2022
mockdockerclient/image_api_client.go
Outdated
| if c.PullResp == nil { | ||
| return nil, Err | ||
| } | ||
| if c.Platform != opts.Platform { |
There was a problem hiding this comment.
Don't perform this check. The mock is designed to be simple and not contain any logic so the test consumer can easily setup test scenarios.
| expectErr bool | ||
| }{ | ||
| {name: "success", client: mockdockerclient.ImageAPIClient{ | ||
| PullResp: mockdockerclient.MockReadCloser{MockReader: successReader}}, expectErr: false}, | ||
| {name: "with specific platform", client: mockdockerclient.ImageAPIClient{ |
dhui
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 👋 Firstly, thank you this awesome package!
This PR adds an option for specifying the platform of the docker image that gets
pulled by the
Runfunction. This option is useful for users with Apple M1 laptopsthat need to pull an image that doesn't have support for the
linux/arm64platform.Instead, such users could pull the standard
linux/amd64image and run it instead(via Rosetta).