Added percentage next to failure count in output #30
Conversation
There was a problem hiding this comment.
Looks good but I think there's a small error in the percentage calculation. I'd recommend running the examples in https://github.com/di/vladiate/blob/master/vladiate/examples/vladfile.py to see if the percentages make sense.
| @@ -85,6 +86,7 @@ def validate(self): | |||
| return False | |||
|
|
|||
| for line, row in enumerate(reader): | |||
| self.line_count = line | |||
There was a problem hiding this comment.
This will set self.line_count multiple times until the loop has finished, and since enumerate produces a zero-indexed list, this causes an off-by-one error where self.line_count is one less than the actual total number of lines.
Instead, you might want to do self.line_count += 1.
Corrected line counting logic to accurately reflect the number of lines actually parsed.
|
Thanks for the feedback and help! |
| validator.__class__.__name__, validator.fail_count, | ||
| field_name)) | ||
| validator.fail_count/self.line_count, field_name)) |
There was a problem hiding this comment.
Another issue here is that in Python 2, dividing two integers with / will produce another integer, so this will always be either 1 or 0. For example:
$ python
Python 2.7.12 (default, Oct 25 2016, 12:32:25)
[GCC 4.2.1 Compatible Apple LLVM 7.3.0 (clang-703.0.31)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> 1/4
0
In Python 3, this has been changed, so at the top of this file you can add the following and we'll have floats instead:
>>> from __future__ import division
>>> 1/4
0.25
Apparently it really matters to have the __future__ imports at the top.
|
Thanks @sterlingpetersen! And congratulations on your first PR! 🎉 |
|
Thanks for your patient mentoring @di! |
Simple changes to add failure percentage inline with failure count. Feedback, editing, and mentoring always welcome. :)
Fixes #29 Percentage for failure counts.