Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ignore_field_order parameter to Vlad class #44

Closed
wants to merge 1 commit into from
Closed

add ignore_field_order parameter to Vlad class #44

wants to merge 1 commit into from

Conversation

gregorkschroeder
Copy link

Issue #43

@di
Copy link
Owner

di commented Sep 28, 2017

Thanks @gregorkschroeder!

The main issue I have with this is that validators is a dictionary, and in Python dictionaries do not have guaranteed order (although sometimes it seems like we can get away with it).

For example, your test might actually fail on some systems and in some versions of Python.

For this to be mergeable, we'd either have to check if the user has made validators an OrderedDict, or allow the user to supply an argument such as column_order. I somewhat prefer the latter, because the presence of this optional arg would also obviate the need for the ignore_field_order argument.

@gregorkschroeder
Copy link
Author

I agree the second option is much preferable. Will re-submit a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants