Add row level validation #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the concept of row-level validation and a basic RowLengthValidator as a proof of concept / first use. This change allows for validators that make use of the row as a whole rather than individual fields. The RowLengthValidator demonstrates this by simply checking the length of the row (a dict returned by csv.DictReader); other uses may include interdependent fields (e.g. A and B are both present or both absent).
Closed
di
approved these changes
May 4, 2023
jonafato
force-pushed
the
row-level-validators
branch
from
038c5c9
to
e710698
Compare
|
I've just added the missing logging, I think this should be good to go. |
|
FYI, this won't be released until I can resolve #80, if you'd like to work on that! |
jonafato
added a commit
to jonafato/vladiate
that referenced
this pull request
Mar 15, 2024
This class attribute and init argument were added in di#82, but this documentation was not included in the initial PR. Additionally, fixes a readme typo.
di
pushed a commit
that referenced
this pull request
Mar 15, 2024
This class attribute and init argument were added in #82, but this documentation was not included in the initial PR. Additionally, fixes a readme typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the concept of row-level validation and a basic RowLengthValidator as a proof of concept / first use. This change allows for validators that make use of the row as a whole rather than individual fields. The RowLengthValidator demonstrates this by simply checking the length of the row (a dict returned by csv.DictReader); other uses may include interdependent fields (e.g. A and B are both present or both absent).
Resolves #81.