Flatten app datastructures #1
Conversation
src/js/actions/spaces.js
Outdated
| return Dataset.load(spaceId, datasetId) | ||
| .then((d) => { dataset = d; return Spaces.dispatchLoad(File.load(dataset)); }) | ||
| .then(() => Spaces.dispatchLoad(Annotation.load(dataset))) | ||
| .then(() => Spaces.dispatchLoad(dataset.index())) |
There was a problem hiding this comment.
theoretically loading the annotations and indexing can happen in parallel
src/js/actions/spaces.js
Outdated
| @@ -151,7 +152,7 @@ export function annotationCommentCreate(annotation, text) { | |||
| * @param {string} text | |||
| */ | |||
| export function annotationCommentUpdate(annotation, id, text) { | |||
| return promiseDispatch(() => (annotation.updateComment(id, text)), ANNOTATION_COMMENT_UPDATE); | |||
| return promiseDispatch(() => (annotation.updateComment(id, text)), DIAG_UPDATE); | |||
There was a problem hiding this comment.
can these few promiseDispatch be Spaces.dispatchUpdate?
There was a problem hiding this comment.
Yes, I'm moving them back to the UI.
src/js/app/spaces.js
Outdated
| */ | ||
| datasets(sid) { | ||
| const id = { space_id: sid }; | ||
| return Dataset.storeListByClass(Dataset, this, id); |
There was a problem hiding this comment.
I'd recommend either doing either
Base.storeListByClass(Dataset, this,id)orDataset.storeListByClass(this, id)and then in the implementation inBaseusethisto figure out what class the method was called on
(yes this is accessible in static methods too)
| if (itemIdx === -1) { | ||
| ret[key] = [...selfs, this]; | ||
| } else { | ||
| ret[key] = [...selfs]; |
There was a problem hiding this comment.
don't we want to replace if already there?
There was a problem hiding this comment.
You should be expressly calling update. Load on the other hand is an upsert.
| if (itemIdx > -1) { | ||
| ret[this._getKey()] = [...selfs.slice(0, itemIdx), insert, ...selfs.slice(itemIdx + 1)]; | ||
| } else { | ||
| ret[this._getKey()] = [...selfs]; |
There was a problem hiding this comment.
do we really need to return a copy in case of noop? (ditto for storeDelete)
There was a problem hiding this comment.
Probably not, I'll fix that up and test.
coccyx
changed the title
No description provided.