Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for all DIAG_* actions to be performed in bulk #3

Merged
merged 1 commit into from
Dec 24, 2017
Merged

add support for all DIAG_* actions to be performed in bulk #3

merged 1 commit into from
Dec 24, 2017

Conversation

ledbit
Copy link
Contributor

@ledbit ledbit commented Dec 23, 2017

No description provided.

@ledbit ledbit requested a review from coccyx December 23, 2017 21:30
coccyx
coccyx reviewed Dec 24, 2017
View reviewed changes
Copy link
Contributor

@coccyx coccyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why it was required, but it reads okay. Seems a little awkward to pass values into class methods which operate on a group of objects. At this point, couldn't we make them all static methods?

@ledbit
Copy link
Contributor Author

ledbit commented Dec 24, 2017 •
edited
Loading

So that we don't trigger 100s of updates after an archive is expanded - which make the UI unresponsive while the rerenders happen
https://github.com/diag/ui/blob/branches/DG-180-take-2/src/js/actions/spaces.js#L263

@coccyx coccyx merged commit bb3cc63 into master Dec 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coccyx coccyx coccyx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ledbit @coccyx