Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure with QuickCheck-2.14.3 #43

Closed
sternenseemann opened this issue Jun 10, 2023 · 4 comments
Closed

Test failure with QuickCheck-2.14.3 #43

sternenseemann opened this issue Jun 10, 2023 · 4 comments

Comments

@sternenseemann
Copy link

Seems new generator behavior in QuickCheck-2.14.3 reveals an issue in the test suite:

Running 1 test suites...
Test suite active-tests: RUNNING...
era/start                               +++ OK, passed 200 tests.
era/end                                 +++ OK, passed 200 tests.
duration                                +++ OK, passed 200 tests.
shiftDyn/start                          +++ OK, passed 200 tests.
shiftDyn/end                            +++ OK, passed 200 tests.
shiftDyn/fun                            +++ OK, passed 200 tests.
active/semi-hom                         +++ OK, passed 200 tests.
ui/id                                   +++ OK, passed 200 tests.
stretch/start                           +++ OK, passed 200 tests.
stretch/dur                             +++ OK, passed 200 tests.
stretchTo/dur                           +++ OK, passed 200 tests; 236 discarded.
during/const                            +++ OK, passed 200 tests; 59 discarded.
during/start                            +++ OK, passed 200 tests.
during/end                              *** Failed! Falsified (after 31 tests):
<Era (Min {getMin = Time {unTime = (-205) % 12}},Max {getMax = Time {unTime = 3583 % 348}})>
<Era (Min {getMin = Time {unTime = 194 % 13}},Max {getMax = Time {unTime = 194 % 13}})>
shift/start                             +++ OK, passed 200 tests.
shift/end                               +++ OK, passed 200 tests.
atTime/start                            +++ OK, passed 200 tests.
atTime/fun                              +++ OK, passed 200 tests.
Test suite active-tests: FAIL
Test suite logged to: dist/test/active-0.2.0.17-active-tests.log
0 of 1 test suites (0 of 1 test cases) passed.

Ref. nick8325/quickcheck#359.

@sternenseemann
Copy link
Author

Probably due to nick8325/quickcheck#296?

@byorgey
Copy link
Member

byorgey commented Jun 10, 2023

Thanks for the report, I'll take a look!

@byorgey
Copy link
Member

byorgey commented Jun 11, 2023

Looks like the during/end property fails when the second era has zero duration, which makes sense since stretching to a duration of zero is undefined. I will update the test to require positive duration.

@byorgey
Copy link
Member

byorgey commented Jun 12, 2023

Uploaded active-0.2.0.18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants