correctly (?) compute shaftScale by solving a quadratic

[byorgey]

Fixes #126. I hope.

Also removes startTangent and endTangent in favor of the new machinery
in Diagrams.Tangent.

[jeffreyrosenbluth]

That looks right. Did it work on t he example in #126?

Sent from my iPad

On Oct 11, 2013, at 12:19 PM, Brent Yorgey notifications@github.com wrote:

Fixes #126. I hope.

Also removes startTangent and endTangent in favor of the new machinery
in Diagrams.Tangent.

You can merge this Pull Request by running

git pull https://github.com/diagrams/diagrams-lib arrow-shaftScale
Or view, comment on, or merge it at:

#127

Commit Summary

correctly (?) compute shaftScale by solving a quadratic
File Changes

M src/Diagrams/TwoD/Arrow.hs (55)
Patch Links:

https://github.com/diagrams/diagrams-lib/pull/127.patch
https://github.com/diagrams/diagrams-lib/pull/127.diff

[bergey]

This looks right to me, and probably is easier to understand than the way I was thinking of. And it produces the expected results on the (9-circle) test diagram.

[bergey]

And on the #126 example.

[byorgey]

Yes, I tried it on both the 9-circle test diagram and the example in #126, both produce the expected results.

[jeffreyrosenbluth]

That's great.

Sent from my iPad

On Oct 11, 2013, at 12:40 PM, Brent Yorgey notifications@github.com wrote:

Yes, I tried it on both the 9-circle test diagram and the example in #126, both produce the expected results.

—
Reply to this email directly or view it on GitHub.