New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly (?) compute shaftScale by solving a quadratic #127

Merged
merged 1 commit into from Oct 11, 2013

Conversation

Projects
None yet
3 participants
@byorgey
Member

byorgey commented Oct 11, 2013

Fixes #126. I hope.

Also removes startTangent and endTangent in favor of the new machinery
in Diagrams.Tangent.

Brent Yorgey
correctly (?) compute shaftScale by solving a quadratic
Fixes #126. I hope.

Also removes startTangent and endTangent in favor of the new machinery
in Diagrams.Tangent.
@jeffreyrosenbluth

This comment has been minimized.

Show comment
Hide comment
@jeffreyrosenbluth

jeffreyrosenbluth Oct 11, 2013

Member

That looks right. Did it work on t he example in #126?

Sent from my iPad

On Oct 11, 2013, at 12:19 PM, Brent Yorgey notifications@github.com wrote:

Fixes #126. I hope.

Also removes startTangent and endTangent in favor of the new machinery
in Diagrams.Tangent.

You can merge this Pull Request by running

git pull https://github.com/diagrams/diagrams-lib arrow-shaftScale
Or view, comment on, or merge it at:

#127

Commit Summary

correctly (?) compute shaftScale by solving a quadratic
File Changes

M src/Diagrams/TwoD/Arrow.hs (55)
Patch Links:

https://github.com/diagrams/diagrams-lib/pull/127.patch
https://github.com/diagrams/diagrams-lib/pull/127.diff

Member

jeffreyrosenbluth commented Oct 11, 2013

That looks right. Did it work on t he example in #126?

Sent from my iPad

On Oct 11, 2013, at 12:19 PM, Brent Yorgey notifications@github.com wrote:

Fixes #126. I hope.

Also removes startTangent and endTangent in favor of the new machinery
in Diagrams.Tangent.

You can merge this Pull Request by running

git pull https://github.com/diagrams/diagrams-lib arrow-shaftScale
Or view, comment on, or merge it at:

#127

Commit Summary

correctly (?) compute shaftScale by solving a quadratic
File Changes

M src/Diagrams/TwoD/Arrow.hs (55)
Patch Links:

https://github.com/diagrams/diagrams-lib/pull/127.patch
https://github.com/diagrams/diagrams-lib/pull/127.diff

@bergey

This comment has been minimized.

Show comment
Hide comment
@bergey

bergey Oct 11, 2013

Member

This looks right to me, and probably is easier to understand than the way I was thinking of. And it produces the expected results on the (9-circle) test diagram.

Member

bergey commented Oct 11, 2013

This looks right to me, and probably is easier to understand than the way I was thinking of. And it produces the expected results on the (9-circle) test diagram.

@bergey

This comment has been minimized.

Show comment
Hide comment
@bergey

bergey Oct 11, 2013

Member

And on the #126 example.

Member

bergey commented Oct 11, 2013

And on the #126 example.

bergey added a commit that referenced this pull request Oct 11, 2013

Merge pull request #127 from diagrams/arrow-shaftScale
correctly (?) compute shaftScale by solving a quadratic

@bergey bergey merged commit b50b9f5 into master Oct 11, 2013

1 check passed

default The Travis CI build passed
Details
@byorgey

This comment has been minimized.

Show comment
Hide comment
@byorgey

byorgey Oct 11, 2013

Member

Yes, I tried it on both the 9-circle test diagram and the example in #126, both produce the expected results.

Member

byorgey commented Oct 11, 2013

Yes, I tried it on both the 9-circle test diagram and the example in #126, both produce the expected results.

@jeffreyrosenbluth

This comment has been minimized.

Show comment
Hide comment
@jeffreyrosenbluth

jeffreyrosenbluth Oct 11, 2013

Member

That's great.

Sent from my iPad

On Oct 11, 2013, at 12:40 PM, Brent Yorgey notifications@github.com wrote:

Yes, I tried it on both the 9-circle test diagram and the example in #126, both produce the expected results.


Reply to this email directly or view it on GitHub.

Member

jeffreyrosenbluth commented Oct 11, 2013

That's great.

Sent from my iPad

On Oct 11, 2013, at 12:40 PM, Brent Yorgey notifications@github.com wrote:

Yes, I tried it on both the 9-circle test diagram and the example in #126, both produce the expected results.


Reply to this email directly or view it on GitHub.

jeffreyrosenbluth added a commit that referenced this pull request Oct 11, 2013

@byorgey byorgey deleted the arrow-shaftScale branch Nov 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment