Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Request] Built-in hotkey support #577

Closed
ghost opened this issue Oct 9, 2021 · 3 comments
Closed

[Request] Built-in hotkey support #577

ghost opened this issue Oct 9, 2021 · 3 comments
Labels
Feature✨
Milestone
Version 1.4.1

Comments

@ghost
Copy link

ghost commented Oct 9, 2021

I'd like a spot to specify hotkeys for choices. Along with obvious design benefits it would be a huge accessibility booster.
@coppolaemilio coppolaemilio added this to the Version 1.4 milestone Oct 10, 2021
@zaknafean
Copy link
Collaborator

zaknafean commented Oct 10, 2021 •
edited
Loading

Turns out adding some basic hotkeys was pretty easy. Implementing them to be assignable in the editor is the current task. Here's what I got.

  • Assign 'default' short cuts 1,2,3,4,5,6,7,8,9,0 to the first 10 buttons to appear if no shortcuts are assigned
  • Add configurable shortcut keys to the choice picker
  • Add a setting to 'show the shortcut key' on choices so a choice of 'Yes' could be '1: Yes' without the user needing to do much else
  • See the difficulty of adding support for InputEventActions (like ui_accept, etc for better controller support)

Definitely an easy 1.4 addition

This was referenced Oct 10, 2021
Merged
Merged
zaknafean added a commit to zaknafean/dialogic that referenced this issue Oct 17, 2021
@zaknafean
Merge branch 'coppolaemilio:main' into hotkey-support-dialogic-godot#577
67a057e
zaknafean added a commit to zaknafean/dialogic that referenced this issue Oct 18, 2021
@zaknafean
Merge branch 'main' into hotkey-support-dialogic-godot#577
9fba481
zaknafean added a commit to zaknafean/dialogic that referenced this issue Oct 18, 2021
@zaknafean
Merge branch 'main' into hotkey-support-dialogic-godot#577
40120db
coppolaemilio added a commit that referenced this issue Oct 19, 2021
@zaknafean @coppolaemilio
Hotkey support #577 (#579)
850864a 
* Escape regular expression characters in names

Fix for #454
New regular expression added to escape regular expression characters that could appear in a name.

* Initial Hotkey support

Support for default hotkeys 1-9
Support for custom hotkeys on choice event

* Enable Default Setting

Toggle for enabling/disabling default shortcut keys

* Hotkey Input mappings

Reverted changes to 'ChoicePicker'
Changed logic to read InputActions from the Settings file

* Cleanup

removed errant print statement

* Default settings

Adjusted default settings to fix first use bugs.
Updated tooltip hint

Co-authored-by: Emilio Coppola <coppolaemilio@gmail.com>
@zaknafean
Copy link
Collaborator

This feature has hit main branch if you'd like to give it a test drive @scribbler957

@coppolaemilio
Copy link
Collaborator

I'll close for now, but feel free to open again if something goes wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature✨
Projects
None yet
Milestone
Version 1.4.1
Development

No branches or pull requests
3 participants
@coppolaemilio @zaknafean @Jowan-Spooner