This repository has been archived by the owner on Dec 15, 2023. It is now read-only.
feat: DT 40 Absolute positioning for popover #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
Hey, where'd we land on this? It's been two months. |
|
@dialpad-drew we're not working on it until Dialtone 6 is done. |
|
@dbecherdialpad aligned changes after tooltip PR, should be ready for review. |
dbecherdialpad
suggested changes
Oct 19, 2021
nikitadialpad
commented
Oct 25, 2021
…into component-popover-DT-40
nikitadialpad
changed the title
dbecherdialpad
approved these changes
Nov 10, 2021
| <div | ||
| :id="!ariaLabelledby && labelledBy" | ||
| ref="anchor" | ||
| > | ||
| <!-- @slot Anchor element that activates the popover. --> |
There was a problem hiding this comment.
should we keep this for the docs @braddialpad?
nikitadialpad
merged commit 2279ad5
into
components-Tooltip-Popover-DT-40-absolute-positioning
braddialpad
added a commit
that referenced
this pull request
Nov 25, 2021
) * DT 40 Absolute positioning for tooltips (#131) * DT 40 Absolute positioning for popovers & tooltips * updates * updates * update tooltip * update tooltip * clean up * refactoring, clean up * resolve comments * resolve comments refactor first iteration stories * update comments * DT 40 Tooltip documentation (#177) * add documentation for Tippy tooltip * update reactive "show" * resolve comments, update eslint config because of an error * update esplint json * DT 40 Tooltip tests (#178) * add documentation for Tippy tooltip * update reactive "show" * update tests * update tests * resolve comments * resolve comments * feat: DT 40 Absolute positioning for popover (#135) * DT 40 Absolute positioning for popovers & tooltips * updates * updates * update tooltip * update tooltip * clean up * refactoring, clean up * resolve comments * popover implementation, decomposition tippy, clean up * add animation, clean up * clean up popover * clean tooltip folder * add import * clean up, updates * DT-40 popover component, refactoring after tooltip implementation * resolve comments * clean up * resolve comments * fix eslint * leftover after merge * leftover after merge * Added test for tooltip tippy; Update components DtLazyShow, popover, tooltip; * chore: update package-lock.json * refactor: after merge * story doc * update story doc * add flip for popover * add implementation "modal" * remove v-click-outside * update documentation * update stories * prevent closing popup when a user blur and focus repeatedly during transition * clean up * update storybook folder for tooltip. * added comment for after-leave event * docs: update * resolve comments * fix typo * update overlay, tests * resolve comments * add comment * popover uv alignments * clean up, update data * clean up, remove prev version tooltip. * update docs * update z-index for tooltip * update border-box for content * add width content prop (anchor), update focus logic, * clean up, rename contentWidth * set empty string to content width by default * package lock * restore tooltip test * clean up tooltip test add new constant to popover update default story * add flushPromises to utils * add $nextTick before setPopoverContentAnchorWidth * update tooltip story Co-authored-by: Brad Paugh <brad.paugh@dialpad.com>
nikitadialpad
pushed a commit
that referenced
this pull request
Nov 25, 2021
# [1.6.0](v1.5.0...v1.6.0) (2021-11-25) ### Bug Fixes * add our alpha sort to list-item. Change slot types to VNode for consistiency ([#202](#202)) ([686b2b9](686b2b9)) ### Features * components tooltip and popover. absolute positioning (dt 40) ([#194](#194)) ([dd9e44d](dd9e44d)), closes [#131](#131) [#177](#177) [#178](#178) [#135](#135)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DT 40 Absolute positioning for tooltips
🛠️ Type Of Change
📖 Description
Contains first iteration for headless Tippy implementation, integration with dialtone and cover accessibility
According to the first iteration previous popover wasn't deleted, export with headless popover wasn't updated as well.
Q:
📝 Checklist
📷 Screenshots / GIFs