fix(message-input): DLT-1672 allow spaces in mention suggestions #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braddialpad
requested review from
juliodialpad,
iropolo,
francisrupert and
ninamarina
as code owners
braddialpad
added
the
no-visual-test
|
✔️ Deploy previews ready! |
ninamarina
reviewed
Mar 26, 2024
| @@ -64,6 +66,7 @@ export default { | |||
| }, | |||
|
|
|||
| onExit () { | |||
| console.log('EXIT'); | |||
There was a problem hiding this comment.
I assume you committed this by mistake 😅
There was a problem hiding this comment.
haha yep, thanks
ninamarina
approved these changes
Mar 26, 2024
|
✔️ Deploy previews ready! |
braddialpad
pushed a commit
that referenced
this pull request
Mar 26, 2024
# [3.117.0](dialtone-vue3/v3.116.1...dialtone-vue3/v3.117.0) (2024-03-26) ### Bug Fixes * **Message Input:** DLT-1672 allow spaces in mention suggestions ([#236](#236)) ([ca796d9](ca796d9)) * **Message Input:** send complete files on add media ([#230](#230)) ([15c609f](15c609f)) * **Message Input:** update mention suggestions rendering ([#229](#229)) ([5535e1f](5535e1f)) * NO-JIRA release not working with new commit convention ([#235](#235)) ([28ff27c](28ff27c)) * rich text editor warning/error cleanup ([#227](#227)) ([a60badb](a60badb)) ### Features * **Message Input:** DLT-1665 add paste event ([#233](#233)) ([d35bf6e](d35bf6e))
braddialpad
pushed a commit
that referenced
this pull request
Mar 26, 2024
# [2.124.0](dialtone-vue2/v2.123.1...dialtone-vue2/v2.124.0) (2024-03-26) ### Bug Fixes * **Message Input:** DLT-1672 allow spaces in mention suggestions ([#236](#236)) ([ca796d9](ca796d9)) * **Message Input:** send complete files on add media ([#230](#230)) ([15c609f](15c609f)) * **Message Input:** update mention suggestions rendering ([#229](#229)) ([5535e1f](5535e1f)) * NO-JIRA release not working with new commit convention ([#235](#235)) ([28ff27c](28ff27c)) * rich text editor warning/error cleanup ([#227](#227)) ([a60badb](a60badb)) ### Features * **Message Input:** DLT-1665 add paste event ([#233](#233)) ([d35bf6e](d35bf6e))
braddialpad
pushed a commit
that referenced
this pull request
Mar 26, 2024
# [9.25.0](dialtone/v9.24.0...dialtone/v9.25.0) (2024-03-26) ### Bug Fixes * **Message Input:** DLT-1672 allow spaces in mention suggestions ([#236](#236)) ([ca796d9](ca796d9)) * **Message Input:** send complete files on add media ([#230](#230)) ([15c609f](15c609f)) * **Message Input:** update mention suggestions rendering ([#229](#229)) ([5535e1f](5535e1f)) * NO-JIRA release not working with new commit convention ([#235](#235)) ([28ff27c](28ff27c)) * rich text editor warning/error cleanup ([#227](#227)) ([a60badb](a60badb)) ### Documentation * DLT-1575 use CodeExampleTabs from Icon to Lazy show ([#232](#232)) ([57f0b98](57f0b98)) * NO-JIRA fix example in blog post ([#234](#234)) ([bb7b28d](bb7b28d)) ### Features * **Message Input:** DLT-1665 add paste event ([#233](#233)) ([d35bf6e](d35bf6e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(message-input): DLT-1672 allow spaces in mention suggestions
Obligatory GIF (super important!)
🛠️ Type Of Change
These types will increment the version number on release:
📖 Jira Ticket
https://dialpad.atlassian.net/browse/DLT-1672
📖 Description
Set allowSpaces option on mention suggestions
💡 Context
Prior to this change typing a space while the mentions dialog was open would cause it to close.
📝 Checklist
For all PRs:
For all Vue changes:
./scripts/dialtone-vue-sync.shscript.🔗 Sources
https://tiptap.dev/docs/editor/api/utilities/suggestion#allow-spaces