Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(message-input): DLT-1665 add paste event #233

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

bianca-artola-dialpad
Copy link
Contributor

add(message-input): DLT-1665 add paste event

Obligatory GIF (super important!)

Obligatory GIF

🛠️ Type Of Change

These types will increment the version number on release:

  • Fix
  • Feature
  • Performance Improvement
  • Refactor

📖 Jira Ticket

https://dialpad.atlassian.net/browse/DLT-1665

📖 Description

Adding paste event on the message-input-recipe component to listen for paste events that contains images. For web side, paste-media event so we can use the data for rendering previews.

💡 Context

On the current input we allow paste for images so we should add this ability. Adding the preview for the image will be done on web side.

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.
  • I have considered the performance impact of my change.

@bianca-artola-dialpad bianca-artola-dialpad added the no-visual-test Add this tag when the PR does not need visual testing label Mar 25, 2024
@bianca-artola-dialpad bianca-artola-dialpad changed the title add(message-input): DLT-1665 add paste event feat(message-input): DLT-1665 add paste event Mar 25, 2024
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-233/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-233/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-233/

Copy link
Contributor

@braddialpad braddialpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bianca-artola-dialpad bianca-artola-dialpad merged commit d35bf6e into staging Mar 26, 2024
14 of 16 checks passed
@bianca-artola-dialpad bianca-artola-dialpad deleted the add/paste-event-msg-input branch March 26, 2024 12:24
braddialpad pushed a commit that referenced this pull request Mar 26, 2024
# [3.117.0](dialtone-vue3/v3.116.1...dialtone-vue3/v3.117.0) (2024-03-26)

### Bug Fixes

* **Message Input:** DLT-1672 allow spaces in mention suggestions ([#236](#236)) ([ca796d9](ca796d9))
* **Message Input:** send complete files on add media ([#230](#230)) ([15c609f](15c609f))
* **Message Input:** update mention suggestions rendering ([#229](#229)) ([5535e1f](5535e1f))
* NO-JIRA release not working with new commit convention ([#235](#235)) ([28ff27c](28ff27c))
* rich text editor warning/error cleanup ([#227](#227)) ([a60badb](a60badb))

### Features

* **Message Input:** DLT-1665 add paste event ([#233](#233)) ([d35bf6e](d35bf6e))
braddialpad pushed a commit that referenced this pull request Mar 26, 2024
# [2.124.0](dialtone-vue2/v2.123.1...dialtone-vue2/v2.124.0) (2024-03-26)

### Bug Fixes

* **Message Input:** DLT-1672 allow spaces in mention suggestions ([#236](#236)) ([ca796d9](ca796d9))
* **Message Input:** send complete files on add media ([#230](#230)) ([15c609f](15c609f))
* **Message Input:** update mention suggestions rendering ([#229](#229)) ([5535e1f](5535e1f))
* NO-JIRA release not working with new commit convention ([#235](#235)) ([28ff27c](28ff27c))
* rich text editor warning/error cleanup ([#227](#227)) ([a60badb](a60badb))

### Features

* **Message Input:** DLT-1665 add paste event ([#233](#233)) ([d35bf6e](d35bf6e))
braddialpad pushed a commit that referenced this pull request Mar 26, 2024
# [9.25.0](dialtone/v9.24.0...dialtone/v9.25.0) (2024-03-26)

### Bug Fixes

* **Message Input:** DLT-1672 allow spaces in mention suggestions ([#236](#236)) ([ca796d9](ca796d9))
* **Message Input:** send complete files on add media ([#230](#230)) ([15c609f](15c609f))
* **Message Input:** update mention suggestions rendering ([#229](#229)) ([5535e1f](5535e1f))
* NO-JIRA release not working with new commit convention ([#235](#235)) ([28ff27c](28ff27c))
* rich text editor warning/error cleanup ([#227](#227)) ([a60badb](a60badb))

### Documentation

* DLT-1575 use CodeExampleTabs from Icon to Lazy show ([#232](#232)) ([57f0b98](57f0b98))
* NO-JIRA fix example in blog post ([#234](#234)) ([bb7b28d](bb7b28d))

### Features

* **Message Input:** DLT-1665 add paste event ([#233](#233)) ([d35bf6e](d35bf6e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-visual-test Add this tag when the PR does not need visual testing
Projects
None yet
2 participants