-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rich text editor warning/error cleanup #227
Conversation
โ๏ธ Deploy previews ready! |
โ๏ธ Deploy previews ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks
# [3.117.0](dialtone-vue3/v3.116.1...dialtone-vue3/v3.117.0) (2024-03-26) ### Bug Fixes * **Message Input:** DLT-1672 allow spaces in mention suggestions ([#236](#236)) ([ca796d9](ca796d9)) * **Message Input:** send complete files on add media ([#230](#230)) ([15c609f](15c609f)) * **Message Input:** update mention suggestions rendering ([#229](#229)) ([5535e1f](5535e1f)) * NO-JIRA release not working with new commit convention ([#235](#235)) ([28ff27c](28ff27c)) * rich text editor warning/error cleanup ([#227](#227)) ([a60badb](a60badb)) ### Features * **Message Input:** DLT-1665 add paste event ([#233](#233)) ([d35bf6e](d35bf6e))
# [2.124.0](dialtone-vue2/v2.123.1...dialtone-vue2/v2.124.0) (2024-03-26) ### Bug Fixes * **Message Input:** DLT-1672 allow spaces in mention suggestions ([#236](#236)) ([ca796d9](ca796d9)) * **Message Input:** send complete files on add media ([#230](#230)) ([15c609f](15c609f)) * **Message Input:** update mention suggestions rendering ([#229](#229)) ([5535e1f](5535e1f)) * NO-JIRA release not working with new commit convention ([#235](#235)) ([28ff27c](28ff27c)) * rich text editor warning/error cleanup ([#227](#227)) ([a60badb](a60badb)) ### Features * **Message Input:** DLT-1665 add paste event ([#233](#233)) ([d35bf6e](d35bf6e))
# [9.25.0](dialtone/v9.24.0...dialtone/v9.25.0) (2024-03-26) ### Bug Fixes * **Message Input:** DLT-1672 allow spaces in mention suggestions ([#236](#236)) ([ca796d9](ca796d9)) * **Message Input:** send complete files on add media ([#230](#230)) ([15c609f](15c609f)) * **Message Input:** update mention suggestions rendering ([#229](#229)) ([5535e1f](5535e1f)) * NO-JIRA release not working with new commit convention ([#235](#235)) ([28ff27c](28ff27c)) * rich text editor warning/error cleanup ([#227](#227)) ([a60badb](a60badb)) ### Documentation * DLT-1575 use CodeExampleTabs from Icon to Lazy show ([#232](#232)) ([57f0b98](57f0b98)) * NO-JIRA fix example in blog post ([#234](#234)) ([bb7b28d](bb7b28d)) ### Features * **Message Input:** DLT-1665 add paste event ([#233](#233)) ([d35bf6e](d35bf6e))
fix: Rich text editor warning/error cleanup
๐ ๏ธ Type Of Change
These types will increment the version number on release:
These types will not increment the version number, but will still deploy to documentation site on release:
๐ Jira Ticket
https://dialpad.atlassian.net/browse/DP-93915
https://dialpad.atlassian.net/browse/DP-93919
๐ Description
Three changes in this PR.
There might be a slight delay in fetching the mention suggestion list from backend due to which the component might not be mounted/rendered. And during this time, we try to access component.ref? where component itself is undefined. Hence have a check onKeyDown() method before accessing ref.
Similarly there can be a case where the message input itself is unmounted (edit message case) and the click event in the recipe is calling focusEditor. Make sure the ref exists before calling .focusEditor() on it.
The other fix is kind of a weird one, sometimes (rarely) even though fullName is set on the dt-avatar in MentionSuggestion.vue , vue still complains that we do not pass fullName or imageAlt. Pretty sure the node.name does exist if node.imageSrc exists. So i do not know why it complains. Adding imageAlt and checking if the error is suppressed when dialtone is updated.
๐ Checklist
For all PRs:
For all Vue changes:
./scripts/dialtone-vue-sync.sh
script.For all CSS changes:
If new component:
packages/dialtone-vue2
orpackages/dialtone-vue3
).packages/dialtone-css
package.apps/dialtone-documentation
.common/components_list.cjs
inpackages/dialtone-vue2
andpackages/dialtone-vue3
๐ฎ Next Steps
๐ท Screenshots / GIFs
๐ Sources