Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: NO-JIRA release not working with new commit convention #235

Merged
merged 3 commits into from
Mar 26, 2024
Merged

fix: NO-JIRA release not working with new commit convention #235

merged 3 commits into from
Mar 26, 2024

Conversation

ninamarina
Copy link
Contributor

@ninamarina ninamarina commented Mar 26, 2024 •
edited
Loading

fix: release not working with new commit convention

After this change the release started failing with this error:

✔ Preparing lint-staged...
       ✔ Running tasks for staged files...
       ✔ Applying modifications from tasks...
       ✔ Cleaning up temporary files...
       ⧗   input: chore(release): dialtone/v9.24.1
       
       * **Message Input:** send complete files on add media ([#230](https://github.com/dialpad/dialtone/issues/230)) ([15c609f](https://github.com/dialpad/dialtone/commit/15c609fe5b66bc6ed71d42514feaf517f467b0bb))
       * **Message Input:** update mention suggestions rendering ([#229](https://github.com/dialpad/dialtone/issues/229)) ([5535e1f](https://github.com/dialpad/dialtone/commit/5535e1fac39f9b20398b03442645986760e36ac2))
       * rich text editor warning/error cleanup ([#227](https://github.com/dialpad/dialtone/issues/227)) ([a60badb](https://github.com/dialpad/dialtone/commit/a60badba71b6ca93a8d9721875e0f3e6576f3479))
       
       
       * NO-JIRA fix example in blog post ([#234](https://github.com/dialpad/dialtone/issues/234)) ([bb7b28d](https://github.com/dialpad/dialtone/commit/bb7b28d23f2b392d87325a7f88ef7198ec45474b))
       ✖   subject may not be empty [subject-empty]
       ✖   type may not be empty [type-empty]
       ✖   jira id(s) may not be empty [jira-empty]
       
       ✖   found 3 problems, 0 warnings
       ⓘ   Get help: https://github.com/dialpad/dialtone/blob/staging/.github/COMMIT_CONVENTION.md

Added NO-JIRA to the release commit message so that it passes the new check

@ninamarina ninamarina marked this pull request as ready for review March 26, 2024 14:14
@ninamarina ninamarina marked this pull request as draft March 26, 2024 18:19
@github-actions GitHub Actions
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-235/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-235/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-235/

@ninamarina ninamarina marked this pull request as ready for review March 26, 2024 18:34
@ninamarina ninamarina added the no-visual-test Add this tag when the PR does not need visual testing label Mar 26, 2024
braddialpad
braddialpad approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@braddialpad braddialpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'm going to merge so I can try it out

@braddialpad braddialpad merged commit 28ff27c into staging Mar 26, 2024
15 of 16 checks passed
@braddialpad braddialpad deleted the fix/release-commit branch March 26, 2024 21:50
braddialpad pushed a commit that referenced this pull request Mar 26, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone-icons/v4.12.1
fa6edd9 
## [4.12.1](dialtone-icons/v4.12.0...dialtone-icons/v4.12.1) (2024-03-26)

### Bug Fixes

* NO-JIRA release not working with new commit convention ([#235](#235)) ([28ff27c](28ff27c))
braddialpad pushed a commit that referenced this pull request Mar 26, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone-tokens/v1.27.2
e2da246 
## [1.27.2](dialtone-tokens/v1.27.1...dialtone-tokens/v1.27.2) (2024-03-26)

### Bug Fixes

* NO-JIRA release not working with new commit convention ([#235](#235)) ([28ff27c](28ff27c))

### Documentation

* add tokens keywords ([#220](#220)) ([20125f4](20125f4))
braddialpad pushed a commit that referenced this pull request Mar 26, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone-css/v8.29.2
6c5e7c1 
## [8.29.2](dialtone-css/v8.29.1...dialtone-css/v8.29.2) (2024-03-26)

### Bug Fixes

* NO-JIRA release not working with new commit convention ([#235](#235)) ([28ff27c](28ff27c))
braddialpad pushed a commit that referenced this pull request Mar 26, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone-vue3/v3.117.0
6ec8eac 
# [3.117.0](dialtone-vue3/v3.116.1...dialtone-vue3/v3.117.0) (2024-03-26)

### Bug Fixes

* **Message Input:** DLT-1672 allow spaces in mention suggestions ([#236](#236)) ([ca796d9](ca796d9))
* **Message Input:** send complete files on add media ([#230](#230)) ([15c609f](15c609f))
* **Message Input:** update mention suggestions rendering ([#229](#229)) ([5535e1f](5535e1f))
* NO-JIRA release not working with new commit convention ([#235](#235)) ([28ff27c](28ff27c))
* rich text editor warning/error cleanup ([#227](#227)) ([a60badb](a60badb))

### Features

* **Message Input:** DLT-1665 add paste event ([#233](#233)) ([d35bf6e](d35bf6e))
braddialpad pushed a commit that referenced this pull request Mar 26, 2024
@semantic-release-bot
chore(release): NO-JIRA eslint-plugin-dialtone/v1.0.2
a48afa1 
## [1.0.2](eslint-plugin-dialtone/v1.0.1...eslint-plugin-dialtone/v1.0.2) (2024-03-26)

### Bug Fixes

* NO-JIRA release not working with new commit convention ([#235](#235)) ([28ff27c](28ff27c))
braddialpad pushed a commit that referenced this pull request Mar 26, 2024
@semantic-release-bot
chore(release): NO-JIRA stylelint-plugin-dialtone/v1.0.2
6da05ba 
## [1.0.2](stylelint-plugin-dialtone/v1.0.1...stylelint-plugin-dialtone/v1.0.2) (2024-03-26)

### Bug Fixes

* NO-JIRA release not working with new commit convention ([#235](#235)) ([28ff27c](28ff27c))
braddialpad pushed a commit that referenced this pull request Mar 26, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone-vue2/v2.124.0
2267983 
# [2.124.0](dialtone-vue2/v2.123.1...dialtone-vue2/v2.124.0) (2024-03-26)

### Bug Fixes

* **Message Input:** DLT-1672 allow spaces in mention suggestions ([#236](#236)) ([ca796d9](ca796d9))
* **Message Input:** send complete files on add media ([#230](#230)) ([15c609f](15c609f))
* **Message Input:** update mention suggestions rendering ([#229](#229)) ([5535e1f](5535e1f))
* NO-JIRA release not working with new commit convention ([#235](#235)) ([28ff27c](28ff27c))
* rich text editor warning/error cleanup ([#227](#227)) ([a60badb](a60badb))

### Features

* **Message Input:** DLT-1665 add paste event ([#233](#233)) ([d35bf6e](d35bf6e))
braddialpad pushed a commit that referenced this pull request Mar 26, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone/v9.25.0
4f834e4 
# [9.25.0](dialtone/v9.24.0...dialtone/v9.25.0) (2024-03-26)

### Bug Fixes

* **Message Input:** DLT-1672 allow spaces in mention suggestions ([#236](#236)) ([ca796d9](ca796d9))
* **Message Input:** send complete files on add media ([#230](#230)) ([15c609f](15c609f))
* **Message Input:** update mention suggestions rendering ([#229](#229)) ([5535e1f](5535e1f))
* NO-JIRA release not working with new commit convention ([#235](#235)) ([28ff27c](28ff27c))
* rich text editor warning/error cleanup ([#227](#227)) ([a60badb](a60badb))

### Documentation

* DLT-1575 use CodeExampleTabs from Icon to Lazy show ([#232](#232)) ([57f0b98](57f0b98))
* NO-JIRA fix example in blog post ([#234](#234)) ([bb7b28d](bb7b28d))

### Features

* **Message Input:** DLT-1665 add paste event ([#233](#233)) ([d35bf6e](d35bf6e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braddialpad braddialpad braddialpad approved these changes

@juliodialpad juliodialpad Awaiting requested review from juliodialpad juliodialpad is a code owner

@iropolo iropolo Awaiting requested review from iropolo iropolo is a code owner

@francisrupert francisrupert Awaiting requested review from francisrupert francisrupert is a code owner

Assignees
No one assigned
Labels
no-visual-test Add this tag when the PR does not need visual testing
Projects
None yet
Milestone
No milestone
2 participants
@ninamarina @braddialpad