-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(message-input): DLT-1672 allow spaces in mention suggestions #236
Conversation
βοΈ Deploy previews ready! |
@@ -64,6 +66,7 @@ export default { | |||
}, | |||
|
|||
onExit () { | |||
console.log('EXIT'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you committed this by mistake π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha yep, thanks
βοΈ Deploy previews ready! |
# [3.117.0](dialtone-vue3/v3.116.1...dialtone-vue3/v3.117.0) (2024-03-26) ### Bug Fixes * **Message Input:** DLT-1672 allow spaces in mention suggestions ([#236](#236)) ([ca796d9](ca796d9)) * **Message Input:** send complete files on add media ([#230](#230)) ([15c609f](15c609f)) * **Message Input:** update mention suggestions rendering ([#229](#229)) ([5535e1f](5535e1f)) * NO-JIRA release not working with new commit convention ([#235](#235)) ([28ff27c](28ff27c)) * rich text editor warning/error cleanup ([#227](#227)) ([a60badb](a60badb)) ### Features * **Message Input:** DLT-1665 add paste event ([#233](#233)) ([d35bf6e](d35bf6e))
# [2.124.0](dialtone-vue2/v2.123.1...dialtone-vue2/v2.124.0) (2024-03-26) ### Bug Fixes * **Message Input:** DLT-1672 allow spaces in mention suggestions ([#236](#236)) ([ca796d9](ca796d9)) * **Message Input:** send complete files on add media ([#230](#230)) ([15c609f](15c609f)) * **Message Input:** update mention suggestions rendering ([#229](#229)) ([5535e1f](5535e1f)) * NO-JIRA release not working with new commit convention ([#235](#235)) ([28ff27c](28ff27c)) * rich text editor warning/error cleanup ([#227](#227)) ([a60badb](a60badb)) ### Features * **Message Input:** DLT-1665 add paste event ([#233](#233)) ([d35bf6e](d35bf6e))
# [9.25.0](dialtone/v9.24.0...dialtone/v9.25.0) (2024-03-26) ### Bug Fixes * **Message Input:** DLT-1672 allow spaces in mention suggestions ([#236](#236)) ([ca796d9](ca796d9)) * **Message Input:** send complete files on add media ([#230](#230)) ([15c609f](15c609f)) * **Message Input:** update mention suggestions rendering ([#229](#229)) ([5535e1f](5535e1f)) * NO-JIRA release not working with new commit convention ([#235](#235)) ([28ff27c](28ff27c)) * rich text editor warning/error cleanup ([#227](#227)) ([a60badb](a60badb)) ### Documentation * DLT-1575 use CodeExampleTabs from Icon to Lazy show ([#232](#232)) ([57f0b98](57f0b98)) * NO-JIRA fix example in blog post ([#234](#234)) ([bb7b28d](bb7b28d)) ### Features * **Message Input:** DLT-1665 add paste event ([#233](#233)) ([d35bf6e](d35bf6e))
fix(message-input): DLT-1672 allow spaces in mention suggestions
Obligatory GIF (super important!)
π οΈ Type Of Change
These types will increment the version number on release:
π Jira Ticket
https://dialpad.atlassian.net/browse/DLT-1672
π Description
Set allowSpaces option on mention suggestions
π‘ Context
Prior to this change typing a space while the mentions dialog was open would cause it to close.
π Checklist
For all PRs:
For all Vue changes:
./scripts/dialtone-vue-sync.sh
script.π Sources
https://tiptap.dev/docs/editor/api/utilities/suggestion#allow-spaces