Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rich editor improvements #142

Merged
merged 5 commits into from
Feb 8, 2024
Merged

Conversation

yorbi-dp
Copy link
Contributor

@yorbi-dp yorbi-dp commented Feb 6, 2024

fix: rich editor improvements

Obligatory GIF (super important!)

Obligatory GIF

🛠️ Type Of Change

These types will increment the version number on release:

  • Fix
  • Feature
  • Performance Improvement
  • Refactor

These types will not increment the version number, but will still deploy to documentation site on release:

  • Documentation
  • Build system
  • CI
  • Style (code style changes, not css changes)
  • Test
  • Other (chore)

📖 Jira Ticket

https://dialpad.atlassian.net/browse/DLT-1523

📖 Description

Some visual improvements in the component/recipe.
Space:

  • Horizontal and vertical padding 8px: var(--dt-space-400)
  • Gap button-groups 12px: d-stack--gap-450 (also added this space/gap to the stack component)
  • Gap between buttons 4px: d-stack--gap-300

Dividers:

  • Update from using the d-divide-x d-divide-black-200 because this takes the last:child, we can add something else that represents these dividers between button groups; here is a proposal style.
height: calc(var(--dt-size-550) + var(--dt-size-300));
width: var(--dt-size-100);
background: var(--dt-color-border-subtle);

Buttons:

  • All button should be: size="xs"
  • Codeblock button icon needs to be update with code-block

💡 Context

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.
  • I have considered the performance impact of my change.

For all CSS changes:

  • I have used design tokens whenever possible.
  • I have considered how this change will behave on different screen sizes.
  • I have visually validated my change in light and dark mode.
  • I have used gap or flexbox properties for layout instead of margin whenever possible.

🔮 Next Steps

https://dialpad.atlassian.net/browse/DLT-1530

@yorbi-dp yorbi-dp self-assigned this Feb 6, 2024
@yorbi-dp yorbi-dp added the no-visual-test Add this tag when the PR does not need visual testing label Feb 6, 2024
Copy link

github-actions bot commented Feb 6, 2024

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-142/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-142/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-142/

Copy link
Contributor

@braddialpad braddialpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! remember to update vue 3 component as well

Copy link

github-actions bot commented Feb 8, 2024

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-142/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-142/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-142/

@yorbi-dp
Copy link
Contributor Author

yorbi-dp commented Feb 8, 2024

Looks great! remember to update vue 3 component as well

Fixed the vue 3 component in the latest commit! :)

@yorbi-dp yorbi-dp merged commit a776d47 into staging Feb 8, 2024
8 checks passed
@yorbi-dp yorbi-dp deleted the dlt-1523-rich-editor-improvements branch February 8, 2024 21:20
braddialpad pushed a commit that referenced this pull request Feb 13, 2024
# [8.25.0](dialtone-css/v8.24.4...dialtone-css/v8.25.0) (2024-02-13)

### Bug Fixes

* load archivo font ([#152](#152)) ([3147749](3147749))
* rich editor improvements ([#142](#142)) ([a776d47](a776d47))

### Features

* text decoration scopes ([#148](#148)) ([5e58ef1](5e58ef1))
braddialpad pushed a commit that referenced this pull request Feb 13, 2024
## [3.108.1](dialtone-vue3/v3.108.0...dialtone-vue3/v3.108.1) (2024-02-13)

### Bug Fixes

* **Emoji:** skeleton display issue ([#150](#150)) ([5ccf8ca](5ccf8ca))
* **Feed Item Row:** change typography to compact ([#149](#149)) ([47f4a45](47f4a45))
* rich editor improvements ([#142](#142)) ([a776d47](a776d47))
braddialpad pushed a commit that referenced this pull request Feb 13, 2024
## [2.115.1](dialtone-vue2/v2.115.0...dialtone-vue2/v2.115.1) (2024-02-13)

### Bug Fixes

* **Emoji:** skeleton display issue ([#150](#150)) ([5ccf8ca](5ccf8ca))
* **Feed Item Row:** change typography to compact ([#149](#149)) ([47f4a45](47f4a45))
* rich editor improvements ([#142](#142)) ([a776d47](a776d47))
braddialpad pushed a commit that referenced this pull request Feb 13, 2024
# [9.13.0](dialtone/v9.12.0...dialtone/v9.13.0) (2024-02-13)

### Bug Fixes

* **Emoji:** skeleton display issue ([#150](#150)) ([5ccf8ca](5ccf8ca))
* extra quotes on font tokens ([#151](#151)) ([ec96822](ec96822))
* **Feed Item Row:** change typography to compact ([#149](#149)) ([47f4a45](47f4a45))
* load archivo font ([#152](#152)) ([3147749](3147749))
* rich editor improvements ([#142](#142)) ([a776d47](a776d47))

### Documentation

* **Typography:** design language ([#75](#75)) ([6d6ecd5](6d6ecd5))

### Features

* new icon user speak ([#147](#147)) ([b8a9ac9](b8a9ac9))
* text decoration scopes ([#148](#148)) ([5e58ef1](5e58ef1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-visual-test Add this tag when the PR does not need visual testing
Projects
None yet
2 participants