Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(feed-item-row): change typography to compact #149

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Conversation

braddialpad
Copy link
Contributor

fix(feed-item-row): change typography to compact

🛠️ Type Of Change

These types will increment the version number on release:

  • Fix

📖 Description

Change the typography to body compact as requested by design.

Render emoji's within the default example so we can validate what it looks like.

@braddialpad braddialpad self-assigned this Feb 9, 2024
@braddialpad braddialpad added the visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests label Feb 9, 2024
Copy link

github-actions bot commented Feb 9, 2024

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-149/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-149/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-149/

Copy link
Contributor

@francisrupert francisrupert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve at least from a design perspective in the interest of unblocking this change. I defer to you or other reviewers for approval from Vue perspective.

@braddialpad braddialpad merged commit 47f4a45 into staging Feb 12, 2024
9 checks passed
@braddialpad braddialpad deleted the row-size branch February 12, 2024 23:21
braddialpad pushed a commit that referenced this pull request Feb 13, 2024
## [3.108.1](dialtone-vue3/v3.108.0...dialtone-vue3/v3.108.1) (2024-02-13)

### Bug Fixes

* **Emoji:** skeleton display issue ([#150](#150)) ([5ccf8ca](5ccf8ca))
* **Feed Item Row:** change typography to compact ([#149](#149)) ([47f4a45](47f4a45))
* rich editor improvements ([#142](#142)) ([a776d47](a776d47))
braddialpad pushed a commit that referenced this pull request Feb 13, 2024
## [2.115.1](dialtone-vue2/v2.115.0...dialtone-vue2/v2.115.1) (2024-02-13)

### Bug Fixes

* **Emoji:** skeleton display issue ([#150](#150)) ([5ccf8ca](5ccf8ca))
* **Feed Item Row:** change typography to compact ([#149](#149)) ([47f4a45](47f4a45))
* rich editor improvements ([#142](#142)) ([a776d47](a776d47))
braddialpad pushed a commit that referenced this pull request Feb 13, 2024
# [9.13.0](dialtone/v9.12.0...dialtone/v9.13.0) (2024-02-13)

### Bug Fixes

* **Emoji:** skeleton display issue ([#150](#150)) ([5ccf8ca](5ccf8ca))
* extra quotes on font tokens ([#151](#151)) ([ec96822](ec96822))
* **Feed Item Row:** change typography to compact ([#149](#149)) ([47f4a45](47f4a45))
* load archivo font ([#152](#152)) ([3147749](3147749))
* rich editor improvements ([#142](#142)) ([a776d47](a776d47))

### Documentation

* **Typography:** design language ([#75](#75)) ([6d6ecd5](6d6ecd5))

### Features

* new icon user speak ([#147](#147)) ([b8a9ac9](b8a9ac9))
* text decoration scopes ([#148](#148)) ([5e58ef1](5e58ef1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests
Projects
None yet
2 participants