Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: load archivo font #152

Merged
merged 1 commit into from
Feb 13, 2024
Merged

fix: load archivo font #152

merged 1 commit into from
Feb 13, 2024

Conversation

braddialpad
Copy link
Contributor

fix: load archivo font

🛠️ Type Of Change

These types will increment the version number on release:

  • Fix

📖 Description

Archivo font was not being loaded even though it was provided in the package and used in utility classes. Added into dialtone-globals.

@braddialpad braddialpad self-assigned this Feb 13, 2024
@github-actions GitHub Actions
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-152/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-152/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-152/

juliodialpad
juliodialpad approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@juliodialpad juliodialpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@braddialpad braddialpad merged commit 3147749 into staging Feb 13, 2024
7 checks passed
@braddialpad braddialpad deleted the fix/archivo branch February 13, 2024 18:30
braddialpad pushed a commit that referenced this pull request Feb 13, 2024
@semantic-release-bot
chore(release): dialtone-css/v8.25.0
3d1de47 
# [8.25.0](dialtone-css/v8.24.4...dialtone-css/v8.25.0) (2024-02-13)

### Bug Fixes

* load archivo font ([#152](#152)) ([3147749](3147749))
* rich editor improvements ([#142](#142)) ([a776d47](a776d47))

### Features

* text decoration scopes ([#148](#148)) ([5e58ef1](5e58ef1))
braddialpad pushed a commit that referenced this pull request Feb 13, 2024
@semantic-release-bot
chore(release): dialtone/v9.13.0
aa01282 
# [9.13.0](dialtone/v9.12.0...dialtone/v9.13.0) (2024-02-13)

### Bug Fixes

* **Emoji:** skeleton display issue ([#150](#150)) ([5ccf8ca](5ccf8ca))
* extra quotes on font tokens ([#151](#151)) ([ec96822](ec96822))
* **Feed Item Row:** change typography to compact ([#149](#149)) ([47f4a45](47f4a45))
* load archivo font ([#152](#152)) ([3147749](3147749))
* rich editor improvements ([#142](#142)) ([a776d47](a776d47))

### Documentation

* **Typography:** design language ([#75](#75)) ([6d6ecd5](6d6ecd5))

### Features

* new icon user speak ([#147](#147)) ([b8a9ac9](b8a9ac9))
* text decoration scopes ([#148](#148)) ([5e58ef1](5e58ef1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliodialpad juliodialpad juliodialpad approved these changes

@iropolo iropolo Awaiting requested review from iropolo iropolo is a code owner

@francisrupert francisrupert Awaiting requested review from francisrupert francisrupert is a code owner

@ninamarina ninamarina Awaiting requested review from ninamarina ninamarina is a code owner

Assignees

@braddialpad braddialpad

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@braddialpad @juliodialpad