fix: extra quotes on font tokens #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braddialpad
requested review from
juliodialpad,
iropolo,
francisrupert and
ninamarina
as code owners
braddialpad
added
the
no-visual-test
|
✔️ Deploy previews ready! |
braddialpad
pushed a commit
that referenced
this pull request
Feb 13, 2024
## [1.23.6](dialtone-tokens/v1.23.5...dialtone-tokens/v1.23.6) (2024-02-13) ### Bug Fixes * extra quotes on font tokens ([#151](#151)) ([ec96822](ec96822))
braddialpad
pushed a commit
that referenced
this pull request
Feb 13, 2024
# [9.13.0](dialtone/v9.12.0...dialtone/v9.13.0) (2024-02-13) ### Bug Fixes * **Emoji:** skeleton display issue ([#150](#150)) ([5ccf8ca](5ccf8ca)) * extra quotes on font tokens ([#151](#151)) ([ec96822](ec96822)) * **Feed Item Row:** change typography to compact ([#149](#149)) ([47f4a45](47f4a45)) * load archivo font ([#152](#152)) ([3147749](3147749)) * rich editor improvements ([#142](#142)) ([a776d47](a776d47)) ### Documentation * **Typography:** design language ([#75](#75)) ([6d6ecd5](6d6ecd5)) ### Features * new icon user speak ([#147](#147)) ([b8a9ac9](b8a9ac9)) * text decoration scopes ([#148](#148)) ([5e58ef1](5e58ef1))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: extra quotes on font tokens
Obligatory GIF (super important!)
🛠️ Type Of Change
These types will increment the version number on release:
📖 Jira Ticket
https://dialpad.atlassian.net/browse/DLT-1550
📖 Description
💡 Context
Noticed in product that font families with spaces in them from dialtone were not being applied at all due to incorrect syntax '"double quotes"' around them like this.
📝 Checklist
For all PRs:
🔮 Next Steps
Release and update in product, remove prior hack that was put in product to fix this.