fix(general-row): give example of contact center row using general row #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braddialpad
added
the
no-visual-test
braddialpad
requested review from
juliodialpad,
iropolo,
francisrupert and
ninamarina
as code owners
31 tasks
|
✔️ Deploy previews ready! |
tiagox
force-pushed
the
DP-91907-leftbar-contact-centers-recipe
branch
from
ab07a62
to
ca9437e
Compare
Base automatically changed from
DP-91907-leftbar-contact-centers-recipe
to
staging
May 16, 2024 18:44
|
Closing, parent PR was merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(general-row): give example of contact center row using general row
Obligatory GIF (super important!)
📖 Description
Addon for @tiagox's PR. Reworked the general row to support a new slot called "secondaryLabel" which can contain the contact center status label, and the changes needed to the action button as well to show an "expand" button.
@tiagox You will still have to implement this into contact_centers_row using general_row, however I have provided a live example in contact_centers_row_default.story.vue that you can check out. I think this should cover all the issues you were having but please let me know if there's anything remaining, or if something I've done here is not going to work correctly with your requirements.