-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix dialtone vue3 structure #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test(combobox, datepicker, dropdown): new test template --------- Co-authored-by: iropolo <ignacio.ropolo@dialpad.com>
* test(combobox, datepicker, dropdown): new test template --------- Co-authored-by: iropolo <ignacio.ropolo@dialpad.com>
* feat: feed item pill recipe * vue3 changes
* test(emoji, emoji-text-wrapper, image-viewer): new test template --------- Co-authored-by: iropolo <ignacio.ropolo@dialpad.com>
… template - vue3 (#1163) * test(emoji, emoji-text-wrapper, image-viewer): new test template * test(emoji-picker): new test template --------- Co-authored-by: iropolo <ignacio.ropolo@dialpad.com>
# [3.83.0](dialpad/dialtone-vue@v3.82.2...v3.83.0) (2023-09-11) ### Features * feed item pill recipe vue3 ([#1160](dialpad/dialtone-vue#1160)) ([1baa335](dialpad/dialtone-vue@1baa335)) * **Message Input:** emoji suggestion ([#1136](dialpad/dialtone-vue#1136)) ([8260745](dialpad/dialtone-vue@8260745))
…mplate (#1166) * test(input, input-group, item-layout, keyboard-shortcut): new test template --------- Co-authored-by: iropolo <ignacio.ropolo@dialpad.com>
…mplate - vue3 (#1167) * test(input, input-group, item-layout, keyboard-shortcut): new test template --------- Co-authored-by: iropolo <ignacio.ropolo@dialpad.com>
* feat: add avatar click event in contact info * Address code review feedbacks * Add `avatarAriaLabel` prop to fix translation issue * Add avatar click event to storybook and fix a11y lint error * disable a11y check for contact_info
# [3.84.0](dialpad/dialtone-vue@v3.83.0...v3.84.0) (2023-09-14) ### Bug Fixes * **Feed Item,feed Item Row:** fix avatar alignment ([#1171](dialpad/dialtone-vue#1171)) ([2f84a6e](dialpad/dialtone-vue@2f84a6e)) * **Image Viewer:** fix close icon not visible on dark mode ([#1169](dialpad/dialtone-vue#1169)) ([7b45537](dialpad/dialtone-vue@7b45537)) ### Features * **Leftbar Row:** add new icon color for contact center type ([#1175](dialpad/dialtone-vue#1175)) ([2401063](dialpad/dialtone-vue@2401063)) * **Message Input:** add focus method ([#1177](dialpad/dialtone-vue#1177)) ([1e113a4](dialpad/dialtone-vue@1e113a4))
# [2.96.0](dialpad/dialtone-vue@v2.95.2...v2.96.0) (2023-09-14) ### Bug Fixes * **Feed Item,feed Item Row:** fix avatar alignment ([#1170](dialpad/dialtone-vue#1170)) ([9c1ca39](dialpad/dialtone-vue@9c1ca39)) * **Image Viewer:** fix close icon not visible on dark mode ([#1168](dialpad/dialtone-vue#1168)) ([f703a16](dialpad/dialtone-vue@f703a16)) ### Features * add `avatar-click` event in contact info ([#1164](dialpad/dialtone-vue#1164)) ([9c9e74b](dialpad/dialtone-vue@9c9e74b)) * feed item pill recipe ([#1135](dialpad/dialtone-vue#1135)) ([e05fdfd](dialpad/dialtone-vue@e05fdfd)) * **Leftbar Row:** add new icon color for contact center type ([#1172](dialpad/dialtone-vue#1172)) ([7a74ad4](dialpad/dialtone-vue@7a74ad4))
* test(link, list-item, list-item-group): new test template --------- Co-authored-by: iropolo <ignacio.ropolo@dialpad.com>
* test(link, list-item, list-item-group): new test template --------- Co-authored-by: iropolo <ignacio.ropolo@dialpad.com>
* feat: add avatar click event in contact info * Address code review feedbacks * Add `avatarAriaLabel` prop to fix translation issue * Add avatar click event to storybook and fix a11y lint error * disable a11y check for contact_info
# [3.85.0](dialpad/dialtone-vue@v3.84.0...v3.85.0) (2023-09-14) ### Bug Fixes * feed pill not exported ([#1181](dialpad/dialtone-vue#1181)) ([c18fc09](dialpad/dialtone-vue@c18fc09)) ### Features * add avatar click event in contact info (vue3) ([#1165](dialpad/dialtone-vue#1165)) ([7d4f645](dialpad/dialtone-vue@7d4f645))
* fix(avatar): change avatar seed algorithm to sync with android * package-lock
* feat(avatar): add clickable behavior * refactor(avatar): dynamically change to button * docs(avatar): clickable variant * test(avatar): clickable variant * move events to top element * fix a11ty * update border colors * add default border to avatar * transparent border
…pen state (#1183) * fix(recipe-callbar-button-with-popover): change event name and sync open state * update unit tests * update story display properties
…pen state - Vue3 (#1184) * fix(recipe-callbar-button-with-popover): change event name and sync open state * update unit tests * update story display properties
* feat: emits a select-skin-tone event when skin tone is selected so we can do what we want with it * change event name to skin-tone (#1313) --------- Co-authored-by: Brad Paugh <brad.paugh@dialpad.com>
# [3.96.0](dialpad/dialtone-vue@v3.95.1...v3.96.0) (2023-11-20) ### Bug Fixes * **Collapsible:** use correct transition timing variable ([#1305](dialpad/dialtone-vue#1305)) ([a8019f3](dialpad/dialtone-vue@a8019f3)) ### Features * **Dp 84718:** emit skin tone when selected ([#1312](dialpad/dialtone-vue#1312)) ([9df6c64](dialpad/dialtone-vue@9df6c64)), closes [#1313](dialpad/dialtone-vue#1313)
* fix: npm run lint not detecting errors * correct vue3 branch issues
…structure (#1315) * consolidates emoji picker pass thru props into an object * reworks default value * refactor: modifies default value of emojiProps
## [3.96.1](dialpad/dialtone-vue@v3.96.0...v3.96.1) (2023-11-24) ### Bug Fixes * npm run lint not detecting errors ([#1317](dialpad/dialtone-vue#1317)) ([bf99a34](dialpad/dialtone-vue@bf99a34)) ### Code Refactoring * **Dp 85018:** modify msg input emoji picker pass through props structure ([#1315](dialpad/dialtone-vue#1315)) ([296d98f](dialpad/dialtone-vue@296d98f))
* feat(emoji-picker): component init * feat(emoji-picker): emoji selector migration * feat(emoji-picker): search emoji * feat(emoji-picker): emoji description and skin selector * feat(emoji-picker): tabset and skin selector keyboard navigation * feat(emoji-picker): skin selector keyboard navigation * feat(emoji-picker): skin selector filtered emojis keyboard navigation * feat(emoji-picker): reactivity issue fix * feat(emoji-picker): reactivity issue fix * feat(emoji-picker): reactivity issue fix * feat(emoji-picker): reactivity issue fix * feat(emoji-picker): close events fix * feat(emoji-picker): mdx * feat(emoji-picker): story fix * feat(emoji-picker): test storybook fix * feat(emoji-picker): test storybook fix * feat(emoji-picker): test storybook fix * feat(emoji-picker): test storybook fix * feat(emoji-picker): test storybook fix * feat(emoji-picker): with popover * feat(emoji-picker): intersectionObserver * feat(emoji-picker): fix with popover template * feat(emoji-picker): test fix storybook * feat(emoji-picker): test fix storybook * feat(emoji-picker): test fix storybook * feat(emoji-picker): test fix storybook * feat(emoji-picker): test fix storybook * feat(emoji-picker): emoji picker tests * feat(emoji-picker): lint fix * feat(emoji-picker): emoji picker with popover open initially * feat(emoji-picker): storybook action events * feat(emoji-picker): emoji picker with popover open on percy visual test * feat(emoji-picker): emoji picker with popover open on percy visual test * feat(emoji-picker): export some constants that might be useful to have * feat(emoji-picker): fix keyboard navigation on filtered emojis * feat(emoji-picker): improve test and tooltip on skintone * set showPopover variable default state --------- Co-authored-by: iropolo <ignacio.ropolo@dialpad.com> Co-authored-by: Julio Ortega <julio.ortega@dialpad.com>
* fix: updates necessary for feed-item-row product implementation * fix a11y error * couple minor spacing improvements
# [2.106.0](dialpad/dialtone-vue@v2.105.1...v2.106.0) (2023-11-29) ### Bug Fixes * **Collapsible:** use correct transition timing variable ([#1304](dialpad/dialtone-vue#1304)) ([53a3f3f](dialpad/dialtone-vue@53a3f3f)) * npm run lint not detecting errors ([#1316](dialpad/dialtone-vue#1316)) ([9eb678f](dialpad/dialtone-vue@9eb678f)) * updates necessary for feed-item-row product implementation ([#1318](dialpad/dialtone-vue#1318)) ([c33a77f](dialpad/dialtone-vue@c33a77f)) ### Features * **Emoji Picker:** emoji picker component ([#1307](dialpad/dialtone-vue#1307)) ([e601f7b](dialpad/dialtone-vue@e601f7b))
juliodialpad
requested review from
iropolo,
francisrupert,
braddialpad and
ninamarina
as code owners
December 1, 2023 21:01
✔️ Dialtone Deploy Preview ready! |
✔️ Dialtone-vue 3 Deploy Preview ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed dialtone-vue 3 structure, previously we wanted to split storybook and library, but found a lot of issues in the process.
this is a huge PR (again) so don't need to review, just creating PR to leave trace and check that workflows are triggering correctly.
** Brought dialtone-vue2 commits by accident here, will merge this before continuing the dialtone-vue2 migration**
Pull Request Checklist
staging
as your pull request's base branch. (All PRs usingproduction
as its base branch will be declined).gulp
scripts successfully compile.Obligatory GIF (super important!)